Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mpi emigration collision checking #150

Merged
merged 20 commits into from
Aug 24, 2022
Merged

Mpi emigration collision checking #150

merged 20 commits into from
Aug 24, 2022

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Aug 16, 2022

Description

  • Added collision checks on the rank emigrants
  • Minor formatting and naming
  • Fixed bug in collisionDetection around particles (endTraversal was missing leading to no collision being detected)
  • Added setters for safe particle ids to aid tests (otherwise ids are not rankspecific in tests)
  • Renamed regular grid decomp tests
  • Added test for collision detection amongst leaving and incoming particles on MPI ranks
  • Added checking for collision between currently migrating particles

Related Pull Requests

Resolved Issues

How Has This Been Tested?

New tests, etc.

gomezzz added 5 commits August 11, 2022 15:56
@gomezzz
Added collision checks on the emigrants
d38563b
@gomezzz
Started working on collision test
8592211
@gomezzz
Added tracking of evaded conjunctions
0014f02
@gomezzz
- Minor formatting and naming
762e783 
- Fixed bug in collisionDetection around particles
- Added setters for safe particle ids to aid tests
- Renamed regular grid decomp
- Added test for collision detection amongst leaving and incoming particles on MPI ranks
- Added check for collision between migrating particles
@gomezzz
Added migrant collision test for regulargrid
848302a
@gomezzz gomezzz added Enhancement New feature or request Refactoring labels Aug 16, 2022
@gomezzz gomezzz requested a review from FG-TUM August 16, 2022 15:06
@gomezzz
Copy link
Collaborator Author

gomezzz commented Aug 16, 2022

@FG-TUM There is a problem with regular grid decomposition. Somehow, the particle communication is not correct and the particles moving from one rank to the other don't arrive. The test is currently failing for that. I don't really wanna spend time on this as we aren't using it right now anyways. Any suggestions?

@gomezzz gomezzz mentioned this pull request Aug 17, 2022
Merged
2 tasks
@gomezzz
Copy link
Collaborator Author

gomezzz commented Aug 17, 2022

Tests are fixed in #151

@FG-TUM
Copy link
Collaborator

FG-TUM commented Aug 18, 2022

@FG-TUM There is a problem with regular grid decomposition. Somehow, the particle communication is not correct and the particles moving from one rank to the other don't arrive. The test is currently failing for that. I don't really wanna spend time on this as we aren't using it right now anyways. Any suggestions?

Either we fix it or we add a warning + issue when using it

@gomezzz gomezzz requested a review from FG-TUM August 18, 2022 11:01
@FG-TUM
Copy link
Collaborator

FG-TUM commented Aug 18, 2022

seems like the tests take forever now?

@gomezzz
Copy link
Collaborator Author

gomezzz commented Aug 18, 2022

seems like the tests take forever now?

I think this happens if they fail, not sure why they don't just fail? If they pass however, they pass normally

Base automatically changed from mpiMadness to main August 24, 2022 07:55
@gomezzz gomezzz merged commit 30e7214 into main Aug 24, 2022
@gomezzz gomezzz deleted the MPI-emigration-collision-checking branch August 24, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FG-TUM FG-TUM Awaiting requested review from FG-TUM

Assignees
No one assigned
Labels
Enhancement New feature or request Refactoring
Projects
None yet
Milestone
No milestone
2 participants
@gomezzz @FG-TUM