Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airtable field update and add unit testing #1514

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

Abellegese
Copy link
Contributor

@Abellegese Abellegese commented Jan 16, 2025

Description

Overview:

This PR modifies the aitable interface and BaseInformation class to incorporate the new fields as below:

Environment Size # to dependency size
Image Size # model docker image size
Computational Performance 1 # computational performance for 1 input sample
Computational Performance 10 # computational performance for 10 input samples
Computational Performance 100 # computational performance for 100 input samples

Also to add adds unit tests for the ReadmeMetadata, BaseInformation classes and Mocked Airtable responses are used for tests.

  • ReadmeMetadata: Tests the write_information() methods to ensure correct data retrieval and README generation.
  • BaseInformation: Verifies that model attributes (title, description, performance metrics, etc.) are correctly set and retrieved using direct assignment.

Tests Added:

  • test_read_information: Confirms correct model data retrieval from Airtable.
  • test_write_information: Ensures the README content is formatted correctly.
  • test_write_information_to_file: Verifies that README content is written to a file.
  • test_base_information_setter: Tests direct assignment of attributes in BaseInformation.
  • test_airtable_interface_ro: Verifies Airtable read-only functionality.
  • test_airtable_interface_rw: Verifies Airtable read-write functionality.
  • test_airtable_metadata_find_record: Confirms correct data retrieval from Airtable metadata.

Related to #1484

@Abellegese Abellegese requested a review from DhanshreeA January 16, 2025 15:52
@DhanshreeA
Copy link
Member

I will update the docstring with more helpful explanation of the fields, but otherwise the PR is great!

@Abellegese
Copy link
Contributor Author

Thanks @DhanshreeA

@DhanshreeA
Copy link
Member

DhanshreeA commented Jan 21, 2025

Update, I've removed the Memory GB field from the BaseInformation class, since it is redundant and nowhere being used. We should drop this from AirTable as well, as @miquelduranfrigola had also pointed out.

@DhanshreeA DhanshreeA merged commit a5ad82a into master Jan 21, 2025
27 checks passed
@DhanshreeA DhanshreeA deleted the refactor/airtable-field-update branch January 21, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants