Final CLI Improvements #1495
Merged
Final CLI Improvements #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the user that predefined cannot be done
DhanshreeA
added a commit
that referenced
this pull request
Jan 14, 2025
* Default to csv always for writing to catalog file * Add filter for test models * Make predefined optional and random sampling the default; also notify the user that predefined cannot be done * WIP * Make relevant changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1486
The PR makes the following updates:
--randomflag is set by default now in the example command, so the example command now indeed generates random samples unlesspredefinedis requested, and an example file actually exists.--as-tableflag for theruncommand has a shorter-tflag now.catalogcommand accepts any extension and supports both tab separated files and comma separated files, however when the file extension is not.tsv, it serializes the file as a CSV by default.examplecommand logs to the user if it is unable to find an example file for the model and that it is generating random samples.