-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test and build pipelines #87
base: main
Are you sure you want to change the base?
Conversation
37a76f9
to
9c22e71
Compare
9c22e71
to
fe3dfb6
Compare
Thanks @DhanshreeA for the summary, I have a few questions: For the specific workflows:
We also need to decide what we do with the Python versions. Testing everything every time with each python version is simply going to be too time consuming. |
Refer to parent issue: ersilia-os/ersilia#1484
This PR introduces significant refactoring to testing and building workflows for all the models within the hub.
Please refer to the attached diagram for an overview of the workflows and the sequence in which they will be triggered.
<TODO: Insert schema here>
Major changes in the PR:
test-model-pr.yml
workflow to useersilia test
command to test a model repository.test-model.yml
workflow to useersilia test
command to test a model repository.dev
when built. Since ersilia now supports fetching models with specific tags, we can leverage that to fetch dev images.latest
tag. This workflow can be found in thetest-model-image.yml
.Minor changes in the PR:
upload-model-to-s3.yml
workflow.Further improvements:
test-model-pr.yml
workflow runs ersilia CLI in a Python 3.10 environment. Technically, ersilia CLI is supported for Python versions 3.8 to 3.12, therefore, regardless of which Python version the model requires, the CLI should be run for the model in all the aforementioned Python versions.