Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give better feedback on common GitHub http errors #21

Merged
merged 2 commits into from
Apr 18, 2020

Conversation

brandly
Copy link
Contributor

@brandly brandly commented Apr 15, 2020

partially addresses #11

i don't think that issue is fixed, but i added some error messages that encourage using an access token. this should help prevent people from getting stuck.

@erkal
Copy link
Owner

erkal commented Apr 17, 2020

this created a conflict because I've merged #18 before.
would you fix it or I can look into it later

@brandly
Copy link
Contributor Author

brandly commented Apr 17, 2020

Yeah I realized that second commit would be an issue. I’ll take care of it soon!

@brandly brandly force-pushed the brandly/github-errors branch from b20c033 to 32e721a Compare April 18, 2020 03:24
@brandly brandly force-pushed the brandly/github-errors branch from 32e721a to ab4bf25 Compare April 18, 2020 03:26
@brandly
Copy link
Contributor Author

brandly commented Apr 18, 2020

@erkal should be good now!

@erkal erkal merged commit 7f143fe into erkal:master Apr 18, 2020
@erkal
Copy link
Owner

erkal commented Apr 18, 2020

👍 thank you very much

erkal pushed a commit that referenced this pull request May 11, 2020
This reverts commit 7f143fe, reversing
changes made to a5c8fd6.
erkal pushed a commit that referenced this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants