Use Cloudflare API instead of Website #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaapmarcus Hey bro, are you missing something?:zany_face: |
myrevery
reviewed
Mar 29, 2023
cloudflare-sync-ips.sh
Outdated
Comment on lines
3
to
4
| CLOUDFLARE_FILE_PATH=${1:-/etc/nginx/cloudflare} | ||
| cf_ips="$(curl -fsLm2 --retry 1 https://api.cloudflare.com/client/v4/ips)" | ||
| CLOUDFLARE_FILE_PATH="/etc/nginx/cloudflare" |
There was a problem hiding this comment.
Here should keep: define default path, also accept custom path option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudflare Website might show a random check if the visitor is a real user instead of a bot this causes the old system to fail
See: hestiacp/hestiacp#3370
Option would be to use the https://api.cloudflare.com/client/v4/ips how ever it will add a dependency on jq a 200kb tools of phrasing json files.
The API it self is free to use and it has been tested in the last 2 days since then no complains about the changes
Also @myrevery to contribute to the PR it self.