ENH: add key update_option for Well to roxar #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Some suggestions are commented in but looks good to me. With future annotations I would suggest not importing the Union type and using the | notation.
Regarding your comment about *args, **kwargs on the factory functions, I think we should make an effort to address this for all the major classes.
Comment on lines
+161
to
+163
| trajectory: str = "Drilled trajectory", | ||
| realisation: int = 0, |
There was a problem hiding this comment.
Is trajectory the trajectory name?
jcrivenaes
force-pushed
the
add-possibility-append-logs-toroxar
branch
from
986d7ac to
7e1cc57
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
==========================================
- Coverage 80.28% 80.28% -0.01%
==========================================
Files 92 92
Lines 13488 13489 +1
Branches 2222 2222
==========================================
Hits 10829 10829
- Misses 1933 1934 +1
Partials 726 726 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #884
This aim with this PR is to make it possible to append selected well logs to the RMS icons. It will potentially speed up execution a lot when multiple wells with multiple logs.
The PR do also some refactoring and simplification in the
_well_roxapi.pymodule, but no complete attempt onmypytyping, which can be a separate PR.