Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead c code #980

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Remove dead c code #980

merged 5 commits into from
Nov 13, 2023

Conversation

mferrera
Copy link
Collaborator

These functions are not used and probably will not be used.

@mferrera mferrera self-assigned this Nov 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #980 (90c3808) into main (fb8d9af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #980   +/-   ##
=======================================
  Coverage   80.30%   80.30%           
=======================================
  Files          92       92           
  Lines       13494    13494           
  Branches     2227     2227           
=======================================
  Hits        10837    10837           
  Misses       1930     1930           
  Partials      727      727           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@mferrera mferrera marked this pull request as ready for review November 13, 2023 08:25
Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the functions were prototypes of ideas I would like to continue at some point, e.g. grd3dp_import_import_xtgeo_grid_grid.c. The goal is the get a very fast format for cloud services (SUMO) with metadata, but the ideas halted due to focus shift at some point.

I agree that this is (import) not in use, while the export counterpart grdcp3d_export_xtgeo_grid.c is not removed in this PR, so you need to remove this also.

In datamodels.rst the XTGeo binary format is also mentioned for 3D grid geometry (line 209), so in case these are removed, you need to change this doc also.

@jcrivenaes
Copy link
Collaborator

Some edit: Perhaps keep the documentation part, as I can see export_xtgcpgeom in _grid_export.py do a "xtgeo" export but not via C, but via pure python. Sorry for introducing confusion, @mferrera

@mferrera
Copy link
Collaborator Author

Thanks, I missed the export file

@mferrera mferrera requested a review from jcrivenaes November 13, 2023 11:32
Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mferrera mferrera merged commit 077ec8a into equinor:main Nov 13, 2023
@mferrera mferrera deleted the remove-dead-c-code branch November 13, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants