Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix typo introduced in function call #975

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

jcrivenaes
Copy link
Collaborator

Closes #973

@jcrivenaes jcrivenaes requested a review from mferrera November 10, 2023 08:51
@codecov-commenter
Copy link

Codecov Report

Merging #975 (f12fdae) into main (013dc03) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #975   +/-   ##
=======================================
  Coverage   80.30%   80.30%           
=======================================
  Files          92       92           
  Lines       13494    13494           
  Branches     2227     2227           
=======================================
  Hits        10837    10837           
  Misses       1930     1930           
  Partials      727      727           
Files Coverage Δ
src/xtgeo/grid3d/grid_property.py 85.05% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We double worked this, sorry -- but the type hint and doc string update are still appropriate

@jcrivenaes jcrivenaes force-pushed the fix-bugs-roxapi-tests branch from f12fdae to 168141c Compare November 10, 2023 09:06
@jcrivenaes jcrivenaes merged commit fb8d9af into equinor:main Nov 10, 2023
26 checks passed
@jcrivenaes jcrivenaes deleted the fix-bugs-roxapi-tests branch November 10, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several RoxAPI spesific tests fails after last weeks updates
3 participants