BLD: Unpin numpy 2 #1285
Merged
BLD: Unpin numpy 2 #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unpins numpy<2 and builds the SWIG C library against numpy >= 2.0.0. Versions of numpy major 2 are backward compatible with numpy 1. Hence we should not see issues in environment where numpy<2 may be maintained for years to come, i.e. RMS environments. The numpy SWIG bindings committed in this repository are not out-of-date in a way that would break compatibility. The last update to them in numpy's repository was two years ago from the time of this commit.
jcrivenaes
force-pushed
the
unpin-numpy-2-jriv
branch
from
306fecf to
6051d83
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1285 +/- ##
==========================================
+ Coverage 80.02% 81.15% +1.12%
==========================================
Files 98 94 -4
Lines 13680 12438 -1242
Branches 2203 1874 -329
==========================================
- Hits 10948 10094 -854
+ Misses 1999 1685 -314
+ Partials 733 659 -74 ☔ View full report in Codecov by Sentry. |
jcrivenaes
force-pushed
the
unpin-numpy-2-jriv
branch
from
6c805c0 to
3dc92fc
Compare
jcrivenaes
force-pushed
the
unpin-numpy-2-jriv
branch
from
7f02479 to
cfcc440
Compare
jcrivenaes
commented
Jan 8, 2025
jcrivenaes
commented
Jan 8, 2025
| mock_file, | ||
| keywords=["PROP"], | ||
| ) as kw: | ||
| with ( |
There was a problem hiding this comment.
RUFF formatting here (and further)
mferrera
approved these changes
Jan 8, 2025
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1233
Resolves #1209
This unpins numpy<2 and builds the SWIG C library against numpy >= 2.0.0. Versions of numpy major 2 are backward compatible with numpy 1 with respect to the C api. Hence we should not see issues in environments where numpy<2 may be maintained for years to come, i.e. RMS environments.
The numpy SWIG bindings committed in this repository are not out-of-date in a way that would break compatibility. The last update to them in numpy's repository was two years ago from the time of this commit.
The PR has been manually tested with RMS 14.2, which applies python 3.11 and numpy==1.24.
As a consequence of supporting numpy>=2 this PR deprecates support for Python 3.8, which hits EOL on October 2024.