Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename: MixingRules -> MixingRuleHandler #1262

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 65.61845% with 164 lines in your changes missing coverage. Please review.

Project coverage is 41.30%. Comparing base (02d8e8b) to head (c56359e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...neqsim/thermo/mixingrule/EosMixingRuleHandler.java 66.74% 107 Missing and 30 partials ⚠️
...neqsim/thermo/mixingrule/CPAMixingRuleHandler.java 52.83% 22 Missing and 3 partials ⚠️
...va/neqsim/thermo/mixingrule/MixingRuleHandler.java 50.00% 1 Missing ⚠️
...c/main/java/neqsim/thermo/system/SystemThermo.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1262   +/-   ##
=========================================
  Coverage     41.29%   41.30%           
- Complexity     6080     6081    +1     
=========================================
  Files           725      726    +1     
  Lines         68579    68583    +4     
  Branches       8190     8190           
=========================================
+ Hits          28323    28326    +3     
- Misses        38555    38556    +1     
  Partials       1701     1701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update!

@asmfstatoil asmfstatoil merged commit 0ca1dc7 into equinor:master Jan 28, 2025
5 checks passed
@asmfstatoil asmfstatoil deleted the ref_mr branch January 28, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants