Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first update of Cv calculation #1259

Merged
merged 11 commits into from
Jan 27, 2025

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Jan 18, 2025

No description provided.

@EvenSol EvenSol linked an issue Jan 18, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 84.05797% with 44 lines in your changes missing coverage. Please review.

Project coverage is 41.30%. Comparing base (540fed8) to head (b747a63).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...icaldesign/valve/ControlValveSizing_IEC_60534.java 84.37% 7 Missing and 18 partials ⚠️
.../mechanicaldesign/valve/ValveMechanicalDesign.java 80.00% 7 Missing and 2 partials ⚠️
...eqsim/process/equipment/valve/ThrottlingValve.java 90.76% 4 Missing and 2 partials ⚠️
...c/main/java/neqsim/thermo/system/SystemThermo.java 0.00% 0 Missing and 2 partials ⚠️
src/main/java/neqsim/util/unit/RateUnit.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1259      +/-   ##
============================================
+ Coverage     41.15%   41.30%   +0.15%     
- Complexity     6030     6074      +44     
============================================
  Files           722      724       +2     
  Lines         68312    68512     +200     
  Branches       8162     8187      +25     
============================================
+ Hits          28112    28301     +189     
+ Misses        38519    38511       -8     
- Partials       1681     1700      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol marked this pull request as ready for review January 27, 2025 22:09
@EvenSol EvenSol merged commit 7c2999b into master Jan 27, 2025
12 checks passed
@EvenSol EvenSol deleted the 1258-inconsistency-in-gas-valve-cv-calculation branch January 27, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in gas valve Cv calculation
2 participants