Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor inspection view #1992

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Refactor inspection view #1992

merged 5 commits into from
Jan 29, 2025
+205 −187

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Jan 29, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol added improvement Improvement to existing functionality frontend Frontend related functionality labels Jan 29, 2025
@Eddasol Eddasol self-assigned this Jan 29, 2025
@Eddasol Eddasol requested a review from mrica-equinor January 29, 2025 11:56
mrica-equinor
mrica-equinor approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@mrica-equinor mrica-equinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Eddasol Eddasol merged commit 6f26595 into equinor:main Jan 29, 2025
12 checks passed
@Eddasol Eddasol deleted the refactor-inspection-view branch January 29, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrica-equinor mrica-equinor mrica-equinor approved these changes

Assignees

@Eddasol Eddasol

Labels
frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eddasol @mrica-equinor