Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove timeseries from postgreSQL database #1965

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Remove timeseries from postgreSQL database #1965

merged 2 commits into from
Jan 22, 2025

Conversation

aeshub
Copy link
Contributor

@aeshub aeshub commented Jan 17, 2025 •
edited
Loading

This functionality has not been used and shoudl thus be removed. In addition, it simplifies an upcoming implementation of postgreSQL database as part of tests.

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@aeshub aeshub added backend Backend related functionality improvement Improvement to existing functionality database-change Will require migration labels Jan 17, 2025
@aeshub aeshub self-assigned this Jan 17, 2025
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@aeshub aeshub force-pushed the refactor-timeseries branch 2 times, most recently from d431852 to 170f195 Compare January 17, 2025 12:19
@aeshub aeshub mentioned this pull request Jan 20, 2025
Merged
10 tasks
@aeshub aeshub force-pushed the refactor-timeseries branch 5 times, most recently from 28e3d31 to 794b0b1 Compare January 21, 2025 12:10
andchiind
andchiind approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will take precautions with updating the migrations out of order in the database.

@aeshub
Remove timeseries from postgreSQL database
897b5cb 
This functionality has not been used and should thus be removed. In addition,
it simplifies an upcoming implementation of postgreSQL database as part of
tests.
@aeshub aeshub force-pushed the refactor-timeseries branch from 794b0b1 to 897b5cb Compare January 22, 2025 09:48
@aeshub
Copy link
Contributor Author

aeshub commented Jan 22, 2025

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@aeshub aeshub merged commit 04e1130 into equinor:main Jan 22, 2025
13 of 14 checks passed
@aeshub aeshub deleted the refactor-timeseries branch January 22, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees

@aeshub aeshub

Labels
backend Backend related functionality database-change Will require migration improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeshub @andchiind