Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inspectionfinding test to become deterministic #1258

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix inspectionfinding test to become deterministic #1258

merged 1 commit into from
Dec 13, 2023

Conversation

UsamaEquinorAFK
Copy link
Contributor

No description provided.

andchiind
andchiind approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good assuming we don't expect to get more than one inspection within a minute

@UsamaEquinorAFK
Copy link
Contributor Author

This looks good assuming we don't expect to get more than one inspection within a minute

I agree, there is a downside to this not having seconds but every finding carries a specific ID so the time is not the only distinguishing factor in any way :)

@UsamaEquinorAFK UsamaEquinorAFK merged commit 17564bd into equinor:main Dec 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UsamaEquinorAFK @andchiind @MuhammadUsama-afk-equinor