Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor create robot query #1245

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Refactor create robot query #1245

merged 2 commits into from
Dec 11, 2023

Conversation

Afonso-2403
Copy link
Contributor

No description provided.

@Afonso-2403 Afonso-2403 added backend Backend related functionality improvement Improvement to existing functionality labels Dec 8, 2023
@Afonso-2403 Afonso-2403 self-assigned this Dec 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@Afonso-2403 Afonso-2403 force-pushed the refactor-create-robot-query branch from 0b27bde to f4d318d Compare December 8, 2023 15:01
andchiind
andchiind approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

backend/api.test/Database/DatabaseUtilities.cs Outdated Show resolved Hide resolved
backend/api/Database/Models/Robot.cs Outdated Show resolved Hide resolved
backend/api.test/Client/RobotTests.cs Outdated Show resolved Hide resolved
@Afonso-2403 Afonso-2403 force-pushed the refactor-create-robot-query branch from f4d318d to db18e00 Compare December 11, 2023 09:57
@Afonso-2403 Afonso-2403 merged commit a46a11e into equinor:main Dec 11, 2023
9 checks passed
@Afonso-2403 Afonso-2403 deleted the refactor-create-robot-query branch December 11, 2023 10:01
@Afonso-2403 Afonso-2403 mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees

@Afonso-2403 Afonso-2403

Labels
backend Backend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Afonso-2403 @andchiind