Only add quotations in dev

not for staging and prod
equinor · Mar 11, 2024 · d296979 · d296979
1 parent 1e4f0e2
commit d296979
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/deploy_to_development.yml b/.github/workflows/deploy_to_development.yml
@@ -54,7 +54,9 @@ jobs:
       Environment: development
       Registry: ghcr.io
       ImageName: ${{ github.repository }}
-      Tag: ${{ needs.get-short-sha.outputs.tag }}
+      # Add quotation marks for the tags used in dev environment,
+      # due to the commit hash can be interpreted as an integer if only numbers
+      Tag: '${{ needs.get-short-sha.outputs.tag }}'
       AuthorEmail: ${{ github.event.head_commit.author.email }}
       AuthorName: ${{ github.event.head_commit.author.name }}
     secrets:

diff --git a/.github/workflows/update_aurora_deployment.yml b/.github/workflows/update_aurora_deployment.yml
@@ -44,19 +44,19 @@ jobs:
         run: |
           COMPONENT=frontend
           TAG_LINE_NUMBER=$(($(grep -n "${{ inputs.Registry }}/${{ inputs.ImageName }}-${COMPONENT}" k8s_kustomize/overlays/${{ inputs.Environment }}/kustomization.yaml |  cut --delimiter=":" --fields=1)+1))
-          sed -i "${TAG_LINE_NUMBER} s/newTag:.*/newTag: '${{ inputs.Tag }}'/" k8s_kustomize/overlays/${{ inputs.Environment }}/kustomization.yaml
+          sed -i "${TAG_LINE_NUMBER} s/newTag:.*/newTag: ${{ inputs.Tag }}/" k8s_kustomize/overlays/${{ inputs.Environment }}/kustomization.yaml
 
       - name: Update backend in file
         run: |
           COMPONENT=backend
           TAG_LINE_NUMBER=$(($(grep -n "${{ inputs.Registry }}/${{ inputs.ImageName }}-${COMPONENT}" k8s_kustomize/overlays/${{ inputs.Environment }}/kustomization.yaml |  cut --delimiter=":" --fields=1)+1))
-          sed -i "${TAG_LINE_NUMBER} s/newTag:.*/newTag: '${{ inputs.Tag }}'/" k8s_kustomize/overlays/${{ inputs.Environment }}/kustomization.yaml
+          sed -i "${TAG_LINE_NUMBER} s/newTag:.*/newTag: ${{ inputs.Tag }}/" k8s_kustomize/overlays/${{ inputs.Environment }}/kustomization.yaml
 
       - name: Update broker in file
         run: |
           COMPONENT=broker
           TAG_LINE_NUMBER=$(($(grep -n "${{ inputs.Registry }}/${{ inputs.ImageName }}-${COMPONENT}" k8s_kustomize/overlays/${{ inputs.Environment }}/kustomization.yaml |  cut --delimiter=":" --fields=1)+1))
-          sed -i "${TAG_LINE_NUMBER} s/newTag:.*/newTag: '${{ inputs.Tag }}'/" k8s_kustomize/overlays/${{ inputs.Environment }}/kustomization.yaml
+          sed -i "${TAG_LINE_NUMBER} s/newTag:.*/newTag: ${{ inputs.Tag }}/" k8s_kustomize/overlays/${{ inputs.Environment }}/kustomization.yaml
 
       - name: Update infrastructure in GitHub
         run: |