feat(data): support emp 2019 #298
Open
+425
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: as there is no history of this data (on the Ministry's website), we will need to keep an eye out for updates to adapt the code accordingly (mainly for changes of file names). Like the one in November 2024, updates can lead to errors that prevent them from being used correctly. Let's hope this doesn't happen again soon, but would it be necessary to warn of these difficulties, for example in the docs, for proper use ? Or try to get an alternative to download EMP data?
PS: Update for EMP, V2 on april 2022, V3 on sept 2023 and V4 on nov 2024 (correction december). So probably no new update before 2026.
Closes #286