Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add docker and apptainer containers #274

Merged
merged 10 commits into from
Jan 7, 2025

Conversation

Nitnelav
Copy link
Collaborator

The docker build works well, the most uncertain part is the github actions.
Right now it builds on every pull request and publishes only when a tag like v1.3.1 is used.

It might need some tweaking before getting it right.

Closes #262

@Nitnelav Nitnelav changed the title Add docker and apptainer containers feat: Add docker and apptainer containers Jan 7, 2025
@sebhoerl
Copy link
Contributor

sebhoerl commented Jan 7, 2025

Can we integrate this with the release creation process @leo-desbureaux-tellae ? Or is it better to do this on every? @Nitnelav Also depends if you think that this rather something that people want to use with the latest development version or with each release (I think we said more or less monthly). And if we do for every PR, will Github complain at some point? Or is it always the same files that are overridden?

@Nitnelav
Copy link
Collaborator Author

Nitnelav commented Jan 7, 2025

I think it should work fine as is ... the way the github action is set is :

  • run a docker build . on every PR just to see if nothing fails, nothing is uploaded to any registry
  • run the full build/sign/upload process on every release with a tag like v*.*.*, so typically after a manual merge of the release-please PR

We could narrow down the first part of the workflow to only the ones that modify the environment.yml file I guess if you want to limit the number of checks per PR.

@sebhoerl
Copy link
Contributor

sebhoerl commented Jan 7, 2025

Yes, true, ok makes sense, then its good to merge I think

@Nitnelav
Copy link
Collaborator Author

Nitnelav commented Jan 7, 2025

OK let's go !

@Nitnelav Nitnelav enabled auto-merge (squash) January 7, 2025 13:07
@Nitnelav Nitnelav merged commit e70a297 into eqasim-org:develop Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker and Apptainer containers ?
2 participants