-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make EPICS CA PORTS and the network subnet configurable #16
Conversation
This is a refresh of the example-services project that makes it fully configurable so that it can use unique PORTS and container network subnet. It's made things a tiny bit more convoluted and has added a few lines of funky bash to environment.sh. Including bash arithmetic evaluation. @coretl @DiamondJoseph your choices are:-
The final choice means that all future compose beamlines would look similar, including those made in the tutorials. |
8c4f31d
to
16d345a
Compare
Why am I hesitant about this change? Because it feels a little off that there is code outside of the compose.yml files to make it work. Up until now the only reason for environment.sh was to set a UID:GID for starting phoebus and that was just because of podman/docker differences. Now I have extended the need for environment.sh and it is adding a prior templating step via sed. This is required because pvagw and phoebus cannot be configured by environment variables as far as I can tell. I could put that templating step inside the phoebus and pvagw containers but that feels more unwieldy (because each time I think of a new thing to make configurable I need to rebuild the containers) UPDATE: I have removed all of the additions to environment.sh and used a |
Intro
This allows a user to set the range of ports and the network subnet that is used by the compose project.
Benefits
https://github.com/epics-containers/example-services/blob/configurable-net/environment.sh#L21-L33
Downsides
there is more setup in environment.sh and perhaps it is less legible as a result EDIT: this downside is fixed by #18