Cleanup clang compiler warnings

.appveyor.yml

@@ -3,17 +3,14 @@
 
 # This is YAML - indentation levels are crucial
 
-cache:
-  - C:\Users\appveyor\.tools
-
 #---------------------------------#
-#       additional packages       #
+#       build cache               #
 #---------------------------------#
+# The AppVeyor cache allowance is way too small (1GB per account across all
+# projects, branches and jobs) to be used for the dependency builds.
 
-install:
-# for the sequencer
-  - cinst re2c
-  - cmd: git submodule update --init --recursive
+cache:
+  - C:\Users\appveyor\.tools
 
 #---------------------------------#
 #       repository cloning        #
@@ -23,14 +20,18 @@ init:
   # Set autocrlf to make batch files work
   - git config --global core.autocrlf true
 
-clone_depth: 50
+clone_depth: 5
 
-# Skipping commits affecting only specific files
-skip_commits:
-  files:
-    - 'documentation/*'
-    - '**/*.md'
-    - '.github/**'
+#---------------------------------#
+#       additional packages       #
+#---------------------------------#
+
+install:
+  - cmd: git submodule update --init --recursive
+
+#---------------------------------#
+#   build matrix configuration    #
+#---------------------------------#
 
 # Build Configurations: dll/static, regular/debug
 configuration:
@@ -43,20 +44,21 @@ configuration:
 environment:
   # common / default variables for all jobs
   SETUP_PATH: .ci-local:.ci
+  EPICS_TEST_IMPRECISE_TIMING: YES
 
   matrix:
-  - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
+  - BASE: 3.15
     CMP: vs2019
-    BASE: 7.0
-  - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
+    APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
+  - BASE: 7.0
     CMP: gcc
-    BASE: 7.0
-  - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
+    APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
+  - BASE: 7.0
     CMP: vs2017
-    BASE: 7.0
-  - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
+    APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
+  - BASE: 7.0
     CMP: vs2019
-    BASE: 3.15
+    APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
 
 # Platform: processor architecture
 platform:
@@ -94,10 +96,8 @@ on_finish:
 #---------------------------------#
 
 notifications:
-
   - provider: Email
     to:
       - [email protected]
     on_build_success: false
-
   - provider: GitHubPullRequest

.github/workflows/ci-scripts-build.yml

@@ -27,8 +27,7 @@ jobs:
       BASE: ${{ matrix.base }}
       CMP: ${{ matrix.cmp }}
       BCFG: ${{ matrix.configuration }}
-      WINE: ${{ matrix.wine }}
-      RTEMS: ${{ matrix.rtems }}
+      CI_CROSS_TARGETS: ${{ matrix.cross }}
       EXTRA: ${{ matrix.extra }}
       TEST: ${{ matrix.test }}
     strategy:
@@ -40,21 +39,21 @@ jobs:
             cmp: gcc
             configuration: default
             base: "7.0"
-            wine: "64"
+            cross: "windows-x64-mingw"
             name: "7.0 Ub-20 gcc-9 + MinGW"
 
           - os: ubuntu-20.04
             cmp: gcc
             configuration: static
             base: "7.0"
-            wine: "64"
+            cross: "windows-x64-mingw"
             name: "7.0 Ub-20 gcc-9 + MinGW, static"
 
           - os: ubuntu-20.04
             cmp: gcc
             configuration: default
             base: "3.15"
-            wine: "64"
+            cross: "windows-x64-mingw"
             name: "3.15 Ub-20 gcc-9 + MinGW"
 
           - os: ubuntu-20.04
@@ -64,6 +63,12 @@ jobs:
             extra: "CMD_CXXFLAGS=-std=c++11"
             name: "7.0 Ub-20 gcc-9 C++11, static"
 
+          - os: ubuntu-20.04
+            cmp: clang
+            configuration: default
+            base: "7.0"
+            name: "7.0 Ub-20 clang-10"
+
           - os: ubuntu-20.04
             cmp: clang
             configuration: default
@@ -75,22 +80,16 @@ jobs:
             cmp: gcc
             configuration: default
             base: "7.0"
-            rtems: "4.10"
+            cross: "RTEMS-pc386-qemu@4.10"
             name: "7.0 Ub-20 gcc-9 + RT-4.10"
 
           - os: ubuntu-20.04
             cmp: gcc
             configuration: default
             base: "7.0"
-            rtems: "4.9"
+            cross: "RTEMS-pc386-qemu@4.9"
             name: "7.0 Ub-20 gcc-9 + RT-4.9"
 
-          - os: ubuntu-20.04
-            cmp: clang
-            configuration: default
-            base: "7.0"
-            name: "7.0 Ub-20 clang-10"
-
           - os: macos-latest
             cmp: clang
             configuration: default
@@ -113,10 +112,10 @@ jobs:
             cmp: gcc
             configuration: static
             base: "7.0"
-            name: "7.0 Win2019 mingw, static"
+            name: "7.0 Win2019 MinGW, static"
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
       with:
         submodules: true
     - name: "apt-get install"
@@ -131,11 +130,14 @@ jobs:
     - name: Run main module tests
       run: python .ci/cue.py test
     - name: Upload tapfiles Artifact
-      uses: actions/upload-artifact@v2
+      if: ${{ always() }}
+      uses: actions/upload-artifact@v3
       with:
         name: tapfiles ${{ matrix.name }}
         path: '**/O.*/*.tap'
+        if-no-files-found: ignore
     - name: Collect and show test results
+      if: ${{ always() }}
       run: python .ci/cue.py test-results
 
   docker:
@@ -148,22 +150,20 @@ jobs:
       BASE: ${{ matrix.base }}
       CMP: ${{ matrix.cmp }}
       BCFG: ${{ matrix.configuration }}
-      WINE: ${{ matrix.wine }}
-      RTEMS: ${{ matrix.rtems }}
       EXTRA: ${{ matrix.extra }}
       TEST: ${{ matrix.test }}
     strategy:
       fail-fast: false
       matrix:
         # Job names also name artifacts, character limitations apply
         include:
-          - name: Linux centos 7
-            image: centos:7
-            cmp: gcc
-            configuration: default
-            base: "7.0"
+          #- name: "CentOS-7"
+          #  image: centos:7
+          #  cmp: gcc
+          #  configuration: default
+          #  base: "7.0"
 
-          - name: Linux fedora latest
+          - name: Fedora-latest
             image: fedora:latest
             cmp: gcc
             configuration: default
@@ -196,7 +196,7 @@ jobs:
         # people would rather just break all existing scripts...
         [ -e /usr/bin/python ] || ln -sf /usr/bin/python3 /usr/bin/python
         python --version
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
       with:
         submodules: true
     - name: Prepare and compile dependencies
@@ -206,9 +206,11 @@ jobs:
     - name: Run main module tests
       run: python .ci/cue.py test
     - name: Upload tapfiles Artifact
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: tapfiles ${{ matrix.name }}
         path: '**/O.*/*.tap'
+        if-no-files-found: ignore
     - name: Collect and show test results
+      if: ${{ always() }}
       run: python .ci/cue.py test-results

p2pApp/gwmain.cpp

@@ -34,7 +34,7 @@ namespace pva = epics::pvAccess;
 
 extern int p2pReadOnly;
 
-namespace {
+namespace p2pgw {
 
 pvd::StructureConstPtr schema(pvd::getFieldCreate()->createFieldBuilder()
                               ->add("version", pvd::pvUInt)
@@ -235,10 +235,12 @@ void gwcr(int lvl, const char *client, const char *channel)
     }
 }
 
-}// namespace
+} // namespace p2pgw
+
 
 int main(int argc, char *argv[])
 {
+    using namespace p2pgw;
     try {
         pva::refTrackRegistrar();
 
@@ -280,7 +282,7 @@ int main(int argc, char *argv[])
             lvl = pva::logLevelDebug;
         else if(arg.debug==3)
             lvl = pva::logLevelTrace;
-        else if(arg.debug>=4)
+        else // arg.debug>=4
             lvl = pva::logLevelAll;
         SET_LOG_LEVEL(lvl);
 

pdbApp/qsrv.cpp

@@ -82,7 +82,7 @@ long dbLoadGroup(const char* fname)
     }
 }
 
-namespace {
+namespace qsrv {
 
 void dbLoadGroupWrap(const char* fname)
 {
@@ -124,16 +124,18 @@ void dbgl(int lvl, const char *pattern)
     }
 }
 
-void QSRVRegistrar()
+} // namespace qsrv
+
+static void QSRVRegistrar()
 {
+    using namespace qsrv;
+
     QSRVRegistrar_counters();
     pva::ChannelProviderRegistry::servers()->addSingleton<PDBProvider>("QSRV");
     epics::iocshRegister<int, const char*, &dbgl>("dbgl", "level", "pattern");
     epics::iocshRegister<const char*, &dbLoadGroupWrap>("dbLoadGroup", "jsonfile");
 }
 
-} // namespace
-
 unsigned qsrvVersion(void)
 {
     return QSRV_VERSION_INT;

testApp/Makefile

@@ -24,7 +24,6 @@ PROD_LIBS += $(EPICS_BASE_IOC_LIBS)
 
 TESTPROD_HOST += testweak
 testweak_SRCS += testweak.cpp
-testweak_LIBS += Com
 TESTS += testweak
 
 TESTPROD_HOST += testtest
@@ -57,14 +56,12 @@ testpvalink_LIBS += qsrv
 
 TESTPROD_HOST += testgroupconfig
 testgroupconfig_SRCS += testgroupconfig
-testgroupconfig_LIBS += qsrv pvAccess pvData
-testgroupconfig_LIBS += $(EPICS_BASE_IOC_LIBS)
+testgroupconfig_LIBS += qsrv
 TESTS += testgroupconfig
 
 TESTPROD_HOST += testdbf_copy
 testdbf_copy_SRCS += testdbf_copy
-testdbf_copy_LIBS += qsrv pvAccess pvData
-testdbf_copy_LIBS += $(EPICS_BASE_IOC_LIBS)
+testdbf_copy_LIBS += qsrv
 TESTS += testdbf_copy
 endif
 

testApp/check_consist.cpp

@@ -7,11 +7,14 @@ namespace pvd = epics::pvData;
 namespace pva = epics::pvAccess;
 
 namespace {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 struct Destroyer {
     pvd::Destroyable::shared_pointer D;
     Destroyer(const pvd::Destroyable::shared_pointer& d) : D(d) {}
     ~Destroyer() { if(D) D->destroy(); }
 };
+#pragma GCC diagnostic pop
 
 struct Releaser {
     pva::Monitor::shared_pointer& mon;