Fix possible NULL deref in NTNDArray::getValueSize() #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showed up as a warning when compiling. The incorrect NULL check in
NTNDArray::getValueSize()
would result inNTNDArray::getValueSize()
always returning 0, or crashing if there is no stored value.As a result, it looks like
NTNDArray::isValid()
would almost always return false, unlesscompressedSize
is also 0: