43 possible change to run to line

CHANGELOG.md

@@ -1,6 +1,10 @@
 
 # Seer Change Log
 
+## [2.4beta] - 2023-XX-XX
+* Prepare for the 2.4 release cycle.
+* Fixed string compares for breakpoint conditions (#184)
+
 ## [2.3] - 2023-11-19
 * In the margins of the source windows, allow CTRL+DoubleClick to do a quick RunToLine or RunToAddress.
 * Add --gdb-program and --gdb-arguments to command line to override settings from Seer's config.

debian/changelog

@@ -1,6 +1,6 @@
-seergdb (2.3) UNRELEASED; urgency=medium
+seergdb (2.4beta) UNRELEASED; urgency=medium
 
-  * Release Seer version 2.3
+  * Release Seer version 2.4beta
 
  -- Ernie Pasveer <[email protected]>  Sun, 11 Nov 2023 22:18:38 +0200
 

src/CMakeLists.txt

@@ -1,6 +1,6 @@
 cmake_minimum_required(VERSION 3.1.0)
 
-project(seergdb VERSION 2.3 LANGUAGES CXX)
+project(seergdb VERSION 2.4.0 LANGUAGES CXX)
 
 set(PROJECT_NAME seergdb)
 

src/SeerDebugDialog.cpp

@@ -21,6 +21,8 @@ SeerDebugDialog::SeerDebugDialog (QWidget* parent) : QDialog(parent) {
     // Set up the UI.
     setupUi(this);
 
+    buttonBox->button(QDialogButtonBox::Ok)->setText("Launch");
+
     // Setup the widgets
     setExecutableName("");
     setExecutableSymbolName("");
@@ -158,9 +160,13 @@ void SeerDebugDialog::setBreakpointMode (const QString& mode) {
     }else if (mode == "infunction") {
         breakpointInFunctionRadioButton->setChecked(true);
         return;
+    }else if (mode == "insource") {
+        breakpointAtSourceRadioButton->setChecked(true);
+        return;
     }
 
-    noBreakpointRadioButton->setChecked(true);
+    // Default of "inmain".
+    breakpointInMainRadioButton->setChecked(true);
 }
 
 QString SeerDebugDialog::breakpointMode () const {
@@ -171,19 +177,39 @@ QString SeerDebugDialog::breakpointMode () const {
         return "inmain";
     }else if (breakpointInFunctionRadioButton->isChecked()) {
         return "infunction";
+    }else if (breakpointAtSourceRadioButton->isChecked()) {
+        return "insource";
     }
 
-    return "none";
+    return "inmain";
 }
 
 void SeerDebugDialog::setBreakpointFunctionName (const QString& nameoraddress) {
+
     breakpointInFunctionLineEdit->setText(nameoraddress);
+
+    if (nameoraddress != "") {
+        breakpointInFunctionRadioButton->setChecked(true);
+    }
 }
 
 QString SeerDebugDialog::breakpointFunctionName () const {
     return breakpointInFunctionLineEdit->text();
 }
 
+void SeerDebugDialog::setBreakpointSourceName (const QString& sourceFilenameAndLineno) {
+
+    breakpointAtSourceLineEdit->setText(sourceFilenameAndLineno);
+
+    if (sourceFilenameAndLineno != "") {
+        breakpointAtSourceRadioButton->setChecked(true);
+    }
+}
+
+QString SeerDebugDialog::breakpointSourceName () const {
+    return breakpointAtSourceLineEdit->text();
+}
+
 void SeerDebugDialog::setShowAssemblyTab (bool flag) {
     showAsseblyTabCheckBox->setChecked(flag);
 }

src/SeerDebugDialog.h

@@ -34,6 +34,8 @@ class SeerDebugDialog : public QDialog, protected Ui::SeerDebugDialogForm {
         QString                 breakpointMode                                  () const;
         void                    setBreakpointFunctionName                       (const QString& nameoraddress);
         QString                 breakpointFunctionName                          () const;
+        void                    setBreakpointSourceName                         (const QString& sourceFilenameAndLineno);
+        QString                 breakpointSourceName                            () const;
         void                    setShowAssemblyTab                              (bool flag);
         bool                    showAssemblyTab                                 () const;
         void                    setRandomizeStartAddress                        (bool flag);