Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): make version view user friendly, add validation (Issue #2956) #3065

Merged
merged 30 commits into from
Jan 31, 2025

Conversation

Derikyan
Copy link
Contributor

@Derikyan Derikyan commented Jan 30, 2025

Description:

  • we should cut version with three dots at the end if there is not enough space to show it on the card.
  • we should restrict to create huge versions for application (custom, for example) - TBD with the team
  • Be sure to check all the cards: on DIAL Marketplace, on Select and agent for conversation

Issues:

UI changes

Before:
Снимок экрана 2025-01-30 в 19 45 12

After:
Снимок экрана 2025-01-30 в 19 45 38

Before:
Снимок экрана 2025-01-30 в 19 47 05

After:
Снимок экрана 2025-01-30 в 19 47 32
Снимок экрана 2025-01-30 в 19 47 51

Before:
Снимок экрана 2025-01-30 в 19 50 11

After:
Снимок экрана 2025-01-30 в 19 50 55

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

IlyaBondar and others added 24 commits December 10, 2024 18:15
@Derikyan Derikyan added the bug Something isn't working label Jan 30, 2025
@Derikyan Derikyan self-assigned this Jan 30, 2025
@Derikyan Derikyan requested a review from likeamike as a code owner January 30, 2025 15:56
@Derikyan
Copy link
Contributor Author

Derikyan commented Jan 30, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3065.nightly-test.deltixhub.io
E2E tests status: failed

IlyaBondar
IlyaBondar previously approved these changes Jan 30, 2025
@Derikyan
Copy link
Contributor Author

Derikyan commented Jan 30, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3065.nightly-test.deltixhub.io
E2E tests status: failed

@irinakartun
Copy link
Contributor

irinakartun commented Jan 31, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3065.nightly-test.deltixhub.io
E2E tests status: failed

@irinakartun
Copy link
Contributor

irinakartun commented Jan 31, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3065.nightly-test.deltixhub.io
E2E tests status: success

@Derikyan Derikyan enabled auto-merge (squash) January 31, 2025 11:54
@Derikyan Derikyan merged commit a859859 into development Jan 31, 2025
8 checks passed
@Derikyan Derikyan deleted the fix/2956-version-friendly-view branch January 31, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants