-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1446 Dearomatization does not work with query features #1455
Merged
AlexanderSavelyev
merged 13 commits into
epam:master
from
AliaksandrDziarkach:bugfix/1446-dearomatize-query-molecules
Dec 27, 2023
Merged
#1446 Dearomatization does not work with query features #1455
AlexanderSavelyev
merged 13 commits into
epam:master
from
AliaksandrDziarkach:bugfix/1446-dearomatize-query-molecules
Dec 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add code to dearomatize query molecules. Add UTs.
Revert indigo_api UT
Fix API and API UT
if (_isQueryMolecule) | ||
{ | ||
if (_molecule.asQueryMolecule().possibleNitrogenV5(v_idx)) | ||
max_connectivity = 5; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
m = indigo.loadSmarts("c1[cX4]cccc1") | ||
print("Aromatic: %s" % m.smarts()) | ||
m.dearomatize() | ||
print("Dearomatized: %s\n" % m.smarts()) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
AlexanderSavelyev
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code to dearomatize query molecules.
Add UTs.