Skip to content

Commit

Permalink
test: 테스트 수정
Browse files Browse the repository at this point in the history
  • Loading branch information
@eom-tae-in
eom-tae-in committed Oct 8, 2024
1 parent a367b4b commit fc65dca
Show file tree
Hide file tree
Showing 32 changed files with 1,413 additions and 1,530 deletions.
202 changes: 202 additions & 0 deletions src/test/java/com/atwoz/job/application/JobServiceTest.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,202 @@
package com.atwoz.job.application;

import com.atwoz.job.application.dto.JobCreateRequest;
import com.atwoz.job.application.dto.JobUpdateRequest;
import com.atwoz.job.domain.Job;
import com.atwoz.job.domain.JobRepository;
import com.atwoz.job.exception.exceptions.JobCodeAlreadyExistedException;
import com.atwoz.job.exception.exceptions.JobNameAlreadyExistedException;
import com.atwoz.job.exception.exceptions.JobNotFoundException;
import com.atwoz.job.infrastructure.JobFakeRepository;
import java.util.Optional;
import java.util.stream.Stream;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayNameGeneration;
import org.junit.jupiter.api.DisplayNameGenerator.ReplaceUnderscores;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;

import static com.atwoz.job.fixture.직업_요청_픽스처.직업_생성_요청_픽스처.직업_생성_요청_생성;
import static com.atwoz.job.fixture.직업_요청_픽스처.직업_생성_요청_픽스처.직업_생성_요청_생성_이름_코드;
import static com.atwoz.job.fixture.직업_요청_픽스처.직업_수정_요청_픽스처.직업_업데이트_요청_생성_이름_코드;
import static com.atwoz.job.fixture.직업_픽스처.직업_생성;
import static com.atwoz.job.fixture.직업_픽스처.직업_생성_이름_코드;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.assertj.core.api.SoftAssertions.assertSoftly;

@DisplayNameGeneration(ReplaceUnderscores.class)
@SuppressWarnings("NonAsciiCharacters")
class JobServiceTest {

private JobService jobService;
private JobRepository jobRepository;

@BeforeEach
void setup() {
jobRepository = new JobFakeRepository();
jobService = new JobService(jobRepository);
}

@Nested
class 직업_저장 {

@Test
void 직업을_저장한다() {
// given
JobCreateRequest jobCreateRequest = 직업_생성_요청_생성();
Long jobId = 1L;

// when
jobService.saveJob(jobCreateRequest);
Optional<Job> foundJob = jobRepository.findJobById(jobId);

// then
assertSoftly(softly -> {
softly.assertThat(foundJob).isPresent();
Job job = foundJob.get();
softly.assertThat(job.getName()).isEqualTo(jobCreateRequest.name());
softly.assertThat(job.getCode()).isEqualTo(jobCreateRequest.code());
});
}

@ParameterizedTest
@MethodSource(value = "invalidJobCreateRequests")
void 이미_존재하는_직업_이름으로_직업을_저장_할_경우_예외가_발생한다(
final String name,
final String jobName,
final String jobCode,
final Class<Exception> exception
) {
// given
jobRepository.save(직업_생성());
JobCreateRequest jobCreateRequest = 직업_생성_요청_생성_이름_코드(jobName, jobCode);

// when & then
assertThatThrownBy(() -> jobService.saveJob(jobCreateRequest))
.isInstanceOf(exception);
}

private static Stream<Arguments> invalidJobCreateRequests() {
return Stream.of(
Arguments.of(
"이미 존재하는 직업 이름으로 생성할 경우",
"job1",
"code2",
JobNameAlreadyExistedException.class
),
Arguments.of(
"이미 존재하는 직업 코드로 생성할 경우",
"job2",
"code1",
JobCodeAlreadyExistedException.class
)
);
}
}

@Nested
class 직업_변경 {

@Test
void 직업을_변경한다() {
// given
Job savedJob = jobRepository.save(직업_생성());
JobUpdateRequest jobUpdateRequest = 직업_업데이트_요청_생성_이름_코드(
savedJob.getName() + "1",
savedJob.getCode() + "1"
);
Long jobId = savedJob.getId();

// when
jobService.updateJob(jobId, jobUpdateRequest);
Optional<Job> foundJob = jobRepository.findJobById(jobId);

// then
assertSoftly(softly -> {
softly.assertThat(foundJob).isPresent();
Job job = foundJob.get();
softly.assertThat(job.getName()).isEqualTo(jobUpdateRequest.name());
softly.assertThat(job.getCode()).isEqualTo(jobUpdateRequest.code());
});
}

@ParameterizedTest
@MethodSource(value = "invalidJobUpdateRequests")
void 기존의_직업_이름_또는_코드가_변경이_없거나_이미_존재하는_값으로_변경할_경우_예외가_발생한다(
final String name,
final String jobName,
final String jobCode,
final Class<Exception> exception
) {
// given
jobRepository.save(직업_생성());
Job savedJob = jobRepository.save(직업_생성_이름_코드("newJob", "newCode"));
JobUpdateRequest jobUpdateRequest = 직업_업데이트_요청_생성_이름_코드(jobName, jobCode);
Long jobId = savedJob.getId();

// when & then
assertThatThrownBy(() -> jobService.updateJob(jobId, jobUpdateRequest))
.isInstanceOf(exception);
}

private static Stream<Arguments> invalidJobUpdateRequests() {
return Stream.of(
Arguments.of(
"변경하려는 직업 이름이 기존의 직업 이름과 동일한 경우",
"newJob",
"code2",
JobNameAlreadyExistedException.class
),
Arguments.of(
"이미 존재하는 직업 이름으로 변경할 경우",
"job1",
"code2",
JobNameAlreadyExistedException.class
),
Arguments.of(
"변경하려는 직업 코드가 기존의 직업 코드와 동일한 경우",
"job2",
"newCode",
JobCodeAlreadyExistedException.class
),
Arguments.of(
"이미 존재하는 직업 코드로 변경할 경우",
"job2",
"code1",
JobCodeAlreadyExistedException.class
)
);
}
}

@Nested
class 직업_삭제 {

@Test
void 직업을_삭제한다() {
// given
Job savedJob = jobRepository.save(직업_생성());
Long jobId = savedJob.getId();

// when
jobService.deleteJob(jobId);

// then
assertThat(jobRepository.findJobById(jobId)).isEmpty();
}

@Test
void 존재하지_않는_직업을_삭제할_경우_예외가_발생한다() {
// given
Long notExistJobId = 1L;

// when & then
assertThatThrownBy(() -> jobService.deleteJob(notExistJobId))
.isInstanceOf(JobNotFoundException.class);
}
}
}
66 changes: 66 additions & 0 deletions src/test/java/com/atwoz/job/domain/JobTest.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
package com.atwoz.job.domain;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayNameGeneration;
import org.junit.jupiter.api.DisplayNameGenerator.ReplaceUnderscores;
import org.junit.jupiter.api.Test;

import static com.atwoz.job.fixture.직업_픽스처.직업_생성;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.SoftAssertions.assertSoftly;

@DisplayNameGeneration(ReplaceUnderscores.class)
@SuppressWarnings("NonAsciiCharacters")
class JobTest {

private Job job;

@BeforeEach
void setup() {
job = 직업_생성();
}

@Test
void 이름과_코드_정보로_직업을_생성한다() {
// given
String jobName = "job1";
String jobCode = "code1";

// when
Job createdJob = Job.createWith(jobName, jobCode);

// then
assertSoftly(softly -> {
softly.assertThat(createdJob.getName()).isEqualTo(jobName);
softly.assertThat(createdJob.getCode()).isEqualTo(jobCode);
});
}

@Test
void 직업의_이름과_코드를_업데이트한다() {
// given
String updateJobName = "job2";
String updateJobCode = "code2";

// when
job.update(updateJobName, updateJobCode);

// then
assertSoftly(softly -> {
softly.assertThat(job.getName()).isEqualTo(updateJobName);
softly.assertThat(job.getCode()).isEqualTo(updateJobCode);
});
}

@Test
void 직업_정보가_일치하면_true를_반환한다() {
// given
Job newJob = 직업_생성();

// when
boolean result = job.isSame(newJob);

// then
assertThat(result).isTrue();
}
}
68 changes: 68 additions & 0 deletions src/test/java/com/atwoz/job/fixture/직업_응답_픽스처.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
package com.atwoz.job.fixture;

import com.atwoz.job.application.dto.JobPagingResponses;
import com.atwoz.job.domain.Job;
import com.atwoz.job.infrasturcture.dto.JobPagingResponse;
import com.atwoz.job.infrasturcture.dto.JobSingleResponse;
import java.util.List;

@SuppressWarnings("NonAsciiCharacters")
public class 직업_응답_픽스처 {

public static class 직업_단건_조회_응답_픽스처 {

private static final String DEFAULT_STYLE_NAME = "style";
private static final String DEFAULT_STYLE_CODE = "code";

public static JobSingleResponse 직업_단건_조회_응답_생성() {
return new JobSingleResponse(
DEFAULT_STYLE_NAME,
DEFAULT_STYLE_CODE
);
}

public static JobSingleResponse 직업_단건_조회_응답_생성_직업(final Job job) {
return new JobSingleResponse(
job.getName(),
job.getCode()
);
}
}

public static class 직업_페이징_조회_응답_픽스처 {

private static final long DEFAULT_HOBBY_ID = 1L;
private static final String DEFAULT_STYLE_NAME = "style";
private static final String DEFAULT_STYLE_CODE = "code";
private static final int DEFAULT_NOW_PAGE = 0;
private static final int DEFAULT_NEXT_PAGE = 1;
private static final int DEFAULT_TOTAL_PAGES = 2;
private static final long DEFAULT_TOTAL_ELEMENTS = 3;

public static JobPagingResponse 직업_페이징_조회_응답_생성() {
return new JobPagingResponse(
DEFAULT_HOBBY_ID,
DEFAULT_STYLE_NAME,
DEFAULT_STYLE_CODE
);
}

public static JobPagingResponse 직업_페이징_조회_응답_생성_직업(final Job job) {
return new JobPagingResponse(
job.getId(),
job.getName(),
job.getCode()
);
}

public static JobPagingResponses 직업_페이징_조회_목록_응답_생성_직업페이징목록응답(final List<JobPagingResponse> responses) {
return JobPagingResponses.builder()
.jobPagingResponses(responses)
.nowPage(DEFAULT_NOW_PAGE)
.nextPage(DEFAULT_NEXT_PAGE)
.totalPages(DEFAULT_TOTAL_PAGES)
.totalElements(DEFAULT_TOTAL_ELEMENTS)
.build();
}
}
}
Loading

0 comments on commit fc65dca

Please sign in to comment.