chore: biome useConsistentArrayTypes

biome.json

@@ -26,7 +26,12 @@
         "noDefaultExport": "off",
         "noParameterProperties": "off",
         "useNamingConvention": "off",
-        "useShorthandArrayType": "off"
+        "useShorthandArrayType": "off",
+        "useConsistentArrayType": {
+          "options": {
+            "syntax": "generic"
+          }
+        }
       },
       "nursery": {
         "useImportRestrictions": "off"

packages/api/src/client.ts

@@ -29,7 +29,7 @@ export function createTokenAuthInterceptor(token: string): Interceptor {
 }
 
 export interface TransportOptions {
-  interceptors?: Interceptor[];
+  interceptors?: Array<Interceptor>;
 }
 
 /**

packages/sdk/src/Asset.ts

@@ -137,7 +137,7 @@ export function getBalancesOf(
   client: PublicClient,
   args: Viem.ContractCallParameters<{
     owner: Address;
-    assets: readonly Address[];
+    assets: ReadonlyArray<Address>;
   }>,
 ) {
   return Promise.all(

packages/sdk/src/Configuration/Policies/AllowedExternalPositionTypes.ts

@@ -11,7 +11,7 @@ export type Settings = {
   /**
    * The external position types that should be allowed.
    */
-  externalPositionTypeIds: readonly bigint[];
+  externalPositionTypeIds: ReadonlyArray<bigint>;
 };
 
 /**

packages/sdk/src/Configuration/Policies/utils/AddressListRegistryPerUserPolicies.ts

@@ -17,8 +17,8 @@ const settingsEncoding = [
 ] as const;
 
 export interface AddressListRegistryPerUserPolicySettings {
-  users: readonly Address[];
-  listsData: readonly AddressListRegistryPolicySettings[];
+  users: ReadonlyArray<Address>;
+  listsData: ReadonlyArray<AddressListRegistryPolicySettings>;
 }
 
 export function encodeAddressListRegistryPerUserPolicySettings({

packages/sdk/src/Configuration/Policies/utils/AddressListRegistryPolicies.ts

@@ -23,10 +23,10 @@ const newAddressListArgsEncoding = [
 ] as const;
 
 export interface AddressListRegistryPolicySettings {
-  existingListIds: readonly bigint[];
+  existingListIds: ReadonlyArray<bigint>;
   newListsArgs: ReadonlyArray<{
     updateType: bigint;
-    initialItems: readonly Address[];
+    initialItems: ReadonlyArray<Address>;
   }>;
 }
 

packages/sdk/src/Configuration/Policies/utils/UintListRegistryPerUserPolicies.ts

@@ -17,8 +17,8 @@ const settingsEncoding = [
 ] as const;
 
 export interface UintListRegistryPerUserPolicySettings {
-  users: readonly Address[];
-  listsData: readonly UintListRegistryPolicySettings[];
+  users: ReadonlyArray<Address>;
+  listsData: ReadonlyArray<UintListRegistryPolicySettings>;
 }
 
 export function encodeUintListRegistryPerUserPolicySettings({

packages/sdk/src/Configuration/Policies/utils/UintListRegistryPolicies.ts

@@ -23,10 +23,10 @@ const newUintListArgsEncoding = [
 ] as const;
 
 export interface UintListRegistryPolicySettings {
-  existingListIds: readonly bigint[];
+  existingListIds: ReadonlyArray<bigint>;
   newListsArgs: ReadonlyArray<{
     updateType: bigint;
-    initialItems: readonly bigint[];
+    initialItems: ReadonlyArray<bigint>;
   }>;
 }
 

packages/sdk/src/Depositor.ts

@@ -83,8 +83,8 @@ export type RedeemSharesForSpecificAssetsParams = {
   comptrollerProxy: Address;
   recipient: Address;
   sharesQuantity: bigint;
-  payoutAssets: readonly Address[];
-  payoutPercentages: readonly bigint[];
+  payoutAssets: ReadonlyArray<Address>;
+  payoutPercentages: ReadonlyArray<bigint>;
 };
 
 export async function getSpecificAssetsRedemptionExpectedAmounts(
@@ -128,8 +128,8 @@ export function redeemSharesInKind(
     comptrollerProxy: Address;
     recipient: Address;
     sharesQuantity: bigint;
-    additionalAssets: readonly Address[];
-    assetsToSkip: readonly Address[];
+    additionalAssets: ReadonlyArray<Address>;
+    assetsToSkip: ReadonlyArray<Address>;
   }>,
 ) {
   return new Viem.PopulatedTransaction({

packages/sdk/src/Performance.ts

@@ -153,8 +153,8 @@ export async function calcCanonicalAssetsTotalValue(
   client: PublicClient,
   args: Viem.ContractCallParameters<{
     valueInterpreter: Address;
-    baseAssets: readonly Address[];
-    amounts: readonly bigint[];
+    baseAssets: ReadonlyArray<Address>;
+    amounts: ReadonlyArray<bigint>;
     quoteAsset: Address;
   }>,
 ) {

packages/sdk/src/Portfolio/Integrations/AaveV2.ts

@@ -108,8 +108,8 @@ const addCollateralEncoding = [
 ] as const;
 
 export type AddCollateralArgs = {
-  aTokens: readonly Address[];
-  amounts: readonly bigint[];
+  aTokens: ReadonlyArray<Address>;
+  amounts: ReadonlyArray<bigint>;
 };
 
 export function addCollateralEncode(args: AddCollateralArgs): Hex {
@@ -143,8 +143,8 @@ const removeCollateralEncoding = [
 ] as const;
 
 export type RemoveCollateralArgs = {
-  aTokens: readonly Address[];
-  amounts: readonly bigint[];
+  aTokens: ReadonlyArray<Address>;
+  amounts: ReadonlyArray<bigint>;
 };
 
 export function removeCollateralEncode(args: RemoveCollateralArgs): Hex {
@@ -179,8 +179,8 @@ const borrowEncoding = [
 ] as const;
 
 export type BorrowArgs = {
-  underlyingTokens: readonly Address[];
-  amounts: readonly bigint[];
+  underlyingTokens: ReadonlyArray<Address>;
+  amounts: ReadonlyArray<bigint>;
 };
 
 export function borrowEncode(args: BorrowArgs): Hex {
@@ -214,8 +214,8 @@ const repayBorrowEncoding = [
 ] as const;
 
 export type RepayBorrowArgs = {
-  underlyingTokens: readonly Address[];
-  amounts: readonly bigint[];
+  underlyingTokens: ReadonlyArray<Address>;
+  amounts: ReadonlyArray<bigint>;
 };
 
 export function repayBorrowEncode(args: RepayBorrowArgs): Hex {
@@ -245,7 +245,7 @@ const claimRewardsEncoding = [
 ] as const;
 
 export type ClaimRewardsArgs = {
-  rewardTokens: readonly Address[];
+  rewardTokens: ReadonlyArray<Address>;
 };
 
 export function claimRewardsEncode(args: ClaimRewardsArgs): Hex {
@@ -288,7 +288,7 @@ export function getRewardsBalance(
   client: PublicClient,
   args: Viem.ContractCallParameters<{
     aaveIncentivesController: Address;
-    assets: readonly Address[];
+    assets: ReadonlyArray<Address>;
     user: Address;
   }>,
 ) {

packages/sdk/src/Portfolio/Integrations/AaveV3.ts

@@ -113,8 +113,8 @@ const addCollateralEncoding = [
 ] as const;
 
 export type AddCollateralArgs = {
-  aTokens: readonly Address[];
-  amounts: readonly bigint[];
+  aTokens: ReadonlyArray<Address>;
+  amounts: ReadonlyArray<bigint>;
   fromUnderlying: boolean;
 };
 
@@ -154,8 +154,8 @@ const removeCollateralEncoding = [
 ] as const;
 
 export type RemoveCollateralArgs = {
-  aTokens: readonly Address[];
-  amounts: readonly bigint[];
+  aTokens: ReadonlyArray<Address>;
+  amounts: ReadonlyArray<bigint>;
   toUnderlying: boolean;
 };
 
@@ -192,8 +192,8 @@ const borrowEncoding = [
 ] as const;
 
 export type BorrowArgs = {
-  underlyingTokens: readonly Address[];
-  amounts: readonly bigint[];
+  underlyingTokens: ReadonlyArray<Address>;
+  amounts: ReadonlyArray<bigint>;
 };
 
 export function borrowEncode(args: BorrowArgs): Hex {
@@ -227,8 +227,8 @@ const repayBorrowEncoding = [
 ] as const;
 
 export type RepayBorrowArgs = {
-  underlyingTokens: readonly Address[];
-  amounts: readonly bigint[];
+  underlyingTokens: ReadonlyArray<Address>;
+  amounts: ReadonlyArray<bigint>;
 };
 
 export function repayBorrowEncode(args: RepayBorrowArgs): Hex {

packages/sdk/src/Portfolio/Integrations/ArbitraryLoan.ts

@@ -143,7 +143,7 @@ const reconcileEncoding = [
 ] as const;
 
 export type ReconcileArgs = {
-  extraAssetsToSweep: readonly Address[];
+  extraAssetsToSweep: ReadonlyArray<Address>;
 };
 
 export function reconcileEncode(args: ReconcileArgs): Hex {
@@ -172,7 +172,7 @@ const closeLoanEncoding = [
 ] as const;
 
 export type CloseLoanArgs = {
-  extraAssetsToSweep: readonly Address[];
+  extraAssetsToSweep: ReadonlyArray<Address>;
 };
 
 export function closeLoanEncode(args: CloseLoanArgs): Hex {

packages/sdk/src/Portfolio/Integrations/BalancerV2.ts

@@ -60,11 +60,11 @@ const lendEncoding = [
 export type LendArgs = {
   poolId: Hex;
   bptAmount: bigint;
-  usedTokens: readonly Address[];
-  usedTokenAmounts: readonly bigint[];
+  usedTokens: ReadonlyArray<Address>;
+  usedTokenAmounts: ReadonlyArray<bigint>;
   request: {
-    assets: readonly Address[];
-    limits: readonly bigint[];
+    assets: ReadonlyArray<Address>;
+    limits: ReadonlyArray<bigint>;
     userData: Hex;
     useInternalBalance: boolean;
   };
@@ -293,9 +293,9 @@ export type TakeOrderArgs = {
     amount: bigint;
     userData: Hex;
   }>;
-  assets: readonly Address[];
-  limits: readonly bigint[];
-  stakingTokens: readonly Address[];
+  assets: ReadonlyArray<Address>;
+  limits: ReadonlyArray<bigint>;
+  stakingTokens: ReadonlyArray<Address>;
 };
 
 export function takeOrderEncode(args: TakeOrderArgs): Hex {
@@ -536,8 +536,8 @@ export async function queryBatchSwap(
   args: Viem.ContractCallParameters<{
     balancerQueries: Address;
     kind: (typeof SwapKind)[keyof typeof SwapKind];
-    swaps: readonly BatchSwapStep[];
-    assets: readonly Address[];
+    swaps: ReadonlyArray<BatchSwapStep>;
+    assets: ReadonlyArray<Address>;
     funds: BatchSwapFunds;
   }>,
 ) {
@@ -576,8 +576,8 @@ export async function queryExit(
     sender: Address;
     recipient: Address;
     request: {
-      assets: readonly Address[];
-      minAmountsOut: readonly bigint[];
+      assets: ReadonlyArray<Address>;
+      minAmountsOut: ReadonlyArray<bigint>;
       userData: Hex;
       toInternalBalance: boolean;
     };
@@ -606,8 +606,8 @@ export async function queryJoin(
     sender: Address;
     recipient: Address;
     request: {
-      assets: readonly Address[];
-      maxAmountsIn: readonly bigint[];
+      assets: ReadonlyArray<Address>;
+      maxAmountsIn: ReadonlyArray<bigint>;
       userData: Hex;
       fromInternalBalance: boolean;
     };
@@ -653,7 +653,7 @@ export function weightedPoolsUserDataBptInForExactTokensOut({
   amountsOut,
   maxBPTAmountIn,
 }: {
-  amountsOut: readonly bigint[];
+  amountsOut: ReadonlyArray<bigint>;
   maxBPTAmountIn: bigint;
 }) {
   return encodeAbiParameters(parseAbiParameters("uint8, uint256[], uint256"), [
@@ -690,7 +690,7 @@ export function weightedPoolsUserDataExactTokensInForBptOut({
   amountsIn,
   bptOut,
 }: {
-  amountsIn: readonly bigint[];
+  amountsIn: ReadonlyArray<bigint>;
   bptOut: bigint;
 }) {
   return encodeAbiParameters(parseAbiParameters(["uint8, uint256[], uint256"]), [
@@ -760,7 +760,7 @@ export function stablePoolsUserDataExactTokensInForBptOut({
   amountsIn,
   bptOut,
 }: {
-  amountsIn: readonly bigint[];
+  amountsIn: ReadonlyArray<bigint>;
   bptOut: bigint;
 }) {
   return encodeAbiParameters(parseAbiParameters(["uint8, uint256[], uint256"]), [
@@ -807,7 +807,7 @@ export function composableStablePoolsUserDataExactTokensInForBptOut({
   amountsIn,
   bptOut,
 }: {
-  amountsIn: readonly bigint[];
+  amountsIn: ReadonlyArray<bigint>;
   bptOut: bigint;
 }) {
   return encodeAbiParameters(parseAbiParameters(["uint8, uint256[], uint256"]), [

packages/sdk/src/Portfolio/Integrations/CompoundV2.ts

@@ -124,8 +124,8 @@ export const createAndAddCollateral = ExternalPositionManager.makeCreateAndUse(
 );
 
 export type AddCollateralArgs = {
-  cTokens: readonly Address[];
-  amounts: readonly bigint[];
+  cTokens: ReadonlyArray<Address>;
+  amounts: ReadonlyArray<bigint>;
 };
 
 export function addCollateralEncode(args: AddCollateralArgs): Hex {
@@ -170,9 +170,9 @@ export const borrow = ExternalPositionManager.makeUse(Action.Borrow, borrowEncod
 export const createAndBorrow = ExternalPositionManager.makeCreateAndUse(Action.Borrow, borrowEncode);
 
 export type BorrowArgs = {
-  cTokens: readonly Address[];
-  amounts: readonly bigint[];
-  underlyingTokens: readonly Address[];
+  cTokens: ReadonlyArray<Address>;
+  amounts: ReadonlyArray<bigint>;
+  underlyingTokens: ReadonlyArray<Address>;
 };
 
 const dataEncoding = [{ name: "cTokens", type: "address[]" }] as const;

packages/sdk/src/Portfolio/Integrations/CompoundV3.ts

@@ -84,7 +84,7 @@ const claimRewardsEncoding = [
 ] as const;
 
 export type ClaimRewardsArgs = {
-  cTokens: readonly Address[];
+  cTokens: ReadonlyArray<Address>;
 };
 
 export function claimRewardsEncode(args: ClaimRewardsArgs): Hex {