Patch rules_foreign_cc to not link bazel default libraries into GNUMake #37632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things that rules_foreign_cc is building, including its own tools, are not built by bazel directly, so don't inject libraries into them. The tooling that's actually building those tools knows what it is doing. This patch should be upstreamed. Signed-off-by: Alejandro R Sedeño <[email protected]>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
reviewed
Dec 12, 2024
Signed-off-by: Alejandro R. Sedeño <[email protected]>
phlax
previously approved these changes
Dec 12, 2024
repokitteh-read-only
bot
removed
the
deps
|
Patch needs more work to scope it down. |
Signed-off-by: Alejandro R. Sedeño <[email protected]>
auto-merge was automatically disabled
December 12, 2024 18:07
Head branch was pushed to by a user without write access
repokitteh-read-only
bot
added
the
deps
asedeno
changed the title
asedeno
changed the title
phlax
approved these changes
Dec 12, 2024
repokitteh-read-only
bot
removed
the
deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upstream
rules_foreign_ccbuilds its own GNUMake, it injects bazel's default libraries intoLDFLAGS, which causes trouble on Darwin in newer versions of Bazel that added-lmto the list of default libraries.As explained nicely in bazel-contrib/rules_foreign_cc#1227, Apple's libm re-exports a bunch of symbols and, due to linker argument order, clobbers some symbols from make itself. We don't need any of the default libraries in GNUMake, so disable the feature to link them.
Risk Level: low
Testing: CI