This repository has been archived by the owner on May 14, 2024. It is now read-only.
Fix account creation failure #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest one is causing password generation issues (e.g. when creating an account):
TypeError: length cannot be null or undefined
at f (webpack-internal:///../../node_modules/libsodium-wrappers/dist/modules/libsodium-wrappers.js:1:18896)
at m (webpack-internal:///../../node_modules/libsodium-wrappers/dist/modules/libsodium-wrappers.js:1:18940)
at Object.Lt [as randombytes_buf] (webpack-internal:///../../node_modules/libsodium-wrappers/dist/modules/libsodium-wrappers.js:1:93208)
at Module.generateSaltToDeriveKey (webpack-internal:///../../packages/shared/crypto/internal/libsodium.ts:261:82)
We can investigate them and fix them in a subsequent PR, for now it is more
prudent to stick with the version that we've been using and upgrade more
carefully.
We're getting `sodium.crypto_pwhash_SALTBYTES` as undefined. jedisct1/libsodium.js#326
The @types package uses a caret import which is bringing a newer libsodium with it, so add an explicit override to pin it to the version that we want.
Deploying with
|
| Latest commit: |
69652de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://de0a6d38.bada-frame.pages.dev |
| Branch Preview URL: | https://account-creation.bada-frame.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was happening because yesterday I'd updated a bunch of dependencies by recreating the
yarn.lock, and our caret dependency on libsodium caused it to also get updated. The newer libsodium version removed an API that we were using.Full details are in the documentation notes I've added in the PR changes itself.
Tested by
I verified the problem using this (it'd print undefined):
After the changes in this PR, it correctly prints 16 and account creation proceeds.