This repository has been archived by the owner on May 14, 2024. It is now read-only.
Locale changes #1650
Merged
Locale changes #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is indeed possible to have a TypeScript type and an array of all of its
possible values without repeating ourselves.
The trick is - while we cannot go from types to values, we can go the other way
around. The sidetrick is - typeof array[number] gives us type of an array's
elements.
Combined, we get this pattern
const fruits = ["banana", "orange"] as const;
type Fruits = (typeof fruits)[number];
Refs:
- https://stackoverflow.com/questions/53154564/how-to-get-all-possible-values-of-a-union-type-to-an-array-or-the-other-way-aro
- https://www.typescriptlang.org/docs/handbook/2/indexed-access-types.html
Deploying with
|
| Latest commit: |
1b6f020
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7fd0990d.bada-frame.pages.dev |
| Branch Preview URL: | https://locale.bada-frame.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been refactored to the way I wanted. The final step is to actually switch over from storing language codes to storing the full locale so that we can handle e.g. pt-BR. That'll be in a subsequent PR.