This repository has been archived by the owner on May 14, 2024. It is now read-only.
Create separate UI package #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarn upgrade "@emotion/react" "@emotion/server" "@emotion/styled" --latest This is to pull in the bugfix for this issue: emotion-js/emotion#3049
This code might anyways be replaced by ONNX
Deploying with
|
| Latest commit: |
eb5bea3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://35bd9f39.bada-frame.pages.dev |
| Branch Preview URL: | https://locale.bada-frame.pages.dev |
yarn workspace photos remove next-transpile-modules
Makes it easier to find these lines, especially when running as the renderer process in the desktop app
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as an attempt to use the correct locale, but I realized that the lack of split packages is wasting time. So here I've just gone ahead and done the package split and creating the prettier/eslint/tsc configs that we want. This involved updating a whole host of things. Including a prettier update, that caused the diff of this PR to balloon up.
Tested
yarn devandyarn build(also addedyarn devandyarn buildas shorcuts foryarn dev:photos/yarn build:photos)