Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update npm package dependencies #9

Merged
merged 1 commit into from
Jan 2, 2018
Merged

Conversation

don-smith
Copy link
Member

The main prompt for this PR is to fix the security vulnerability caused by the outdated ecstatic package, but since I was already in there, I updated all of the other npm packages that were listed in npm outdated.

I also did these things:

  • Replace the myth package with myth6 because of this issue: obj.hasOwnProperty is not a function segmentio/myth#149.

  • Fix the name of this app in the package.json file. It must have initially been called slidedeck.

  • Update the license to an official SPDX code.

  • Add a console.log to the server startup to keep from having to look into server.js to know what port the service is running on

  • Remove the test section from the README because there are no tests to run.

I'm attaching 3 reviewers, but 1 should suffice. I don't have access.

Don't forget to deploy after you merge this.

@ahdinosaur ahdinosaur merged commit a2dce70 into enspiral:master Jan 2, 2018
@ahdinosaur
Copy link
Member

yay thanks @don-smith!

@ahdinosaur
Copy link
Member

ahdinosaur commented Jan 2, 2018

deployed: http://whatis.enspiral.com 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants