Display component evaluating status #12126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
added
the
CI: No changelog needed
kazcw
requested review from
Frizi,
farmaazon,
vitvakatu and
AdRiley
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
farmaazon
reviewed
Jan 24, 2025
Comment on lines
85
to
88
| const evaluating = computed(() => { | ||
| const status = graphDb.getExpressionInfo(toValue(externalId))?.payload.type | ||
| return status === 'Pending' || status === undefined | ||
| }) |
There was a problem hiding this comment.
Task specs states, that we should display node as "evaluating" only when payload.progress > 0.
Engine does not send us progress (yet), but we may test it in integration tests (we already have mockExpressionUpdate)
farmaazon
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Components being evaluated show loading animation in icon position.
Gravacao.do.ecra.2025-01-23.as.14.07.19.mov
(Video demonstrates UI, but progress updates triggering this state are not sent by backend yet.)
Fixes #7577.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.