Use AG Grid filter types #12072
Merged
Use AG Grid filter types #12072
+198
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Storybook is successfully deployed!📊 Dashboard:
|
marthasharkey
requested review from
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
kazcw
approved these changes
Jan 22, 2025
Comment on lines
331
to
334
| case 'Integer': | ||
| case 'Float': | ||
| case 'Decimal': | ||
| case 'Byte': |
There was a problem hiding this comment.
This could use isNumericType
| toValue: string | ||
| fromValue: string | ||
| } | ||
| //The filter value can be a single value for comparisons such as 'equals' or 'greater than,' a list for 'is in' filtering, or two values that define a range. |
Comment on lines
17
to
26
| type FilterAction = | ||
| | 'equals' | ||
| | 'notEqual' | ||
| | 'greaterThan' | ||
| | 'greaterThanOrEqual' | ||
| | 'lessThan' | ||
| | 'lessThanOrEqual' | ||
| | 'inRange' | ||
| | 'blank' | ||
| | 'notBlank' |
There was a problem hiding this comment.
Suggested change
| type FilterAction = | |
| | 'equals' | |
| | 'notEqual' | |
| | 'greaterThan' | |
| | 'greaterThanOrEqual' | |
| | 'lessThan' | |
| | 'lessThanOrEqual' | |
| | 'inRange' | |
| | 'blank' | |
| | 'notBlank' | |
| type FilterAction = keyof typeof ActionMap |
marthasharkey
added
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.