Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve scatterplot legend entance/exits #12013

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Improve scatterplot legend entance/exits #12013

merged 5 commits into from
Jan 23, 2025

Conversation

marthasharkey
Copy link
Contributor

@marthasharkey marthasharkey commented Jan 7, 2025 •
edited
Loading

Pull Request Description

Tech debt to improve the way entrances and exits are done in the d3 legend

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@marthasharkey marthasharkey added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 8, 2025
@marthasharkey marthasharkey marked this pull request as ready for review January 8, 2025 11:37
@marthasharkey marthasharkey added the CI: Ready to merge This PR is eligible for automatic merge label Jan 16, 2025
@mergify mergify bot merged commit 2000918 into develop Jan 23, 2025
40 checks passed
@mergify mergify bot deleted the wip/mk/scatterplot-tech-debt branch January 23, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frizi Frizi Frizi approved these changes

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scatterplot legend: handle updates
2 participants
@marthasharkey @Frizi