Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache the parsed markdows in the docs #11990

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Jan 6, 2025

Pull Request Description

This PR removes caching images in the Persister, which could potentially cause bugs

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount self-assigned this Jan 6, 2025
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug g-dashboard labels Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

@MrFlashAccount MrFlashAccount added the CI: Ready to merge This PR is eligible for automatic merge label Jan 7, 2025
@mergify mergify bot merged commit 785d9d1 into develop Jan 7, 2025
41 of 42 checks passed
@mergify mergify bot deleted the wip/sergeigarin/do-not-cache-images branch January 7, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants