Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear excel cache on reload #11872

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Clear excel cache on reload #11872

merged 4 commits into from
Dec 18, 2024
+48 −1

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Dec 13, 2024 •
edited
Loading

Closes #11900

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 13, 2024
@GregoryTravis GregoryTravis marked this pull request as ready for review December 17, 2024 20:56
radeusgd
radeusgd reviewed Dec 18, 2024
View reviewed changes
test/Table_Tests/src/IO/Excel_Spec.enso
check_workbook <| xlsx_sheet.read
ExcelConnectionPool.INSTANCE.getConnectionRecordCount . should_equal 1
check_workbook <| xls_sheet.read
ExcelConnectionPool.INSTANCE.getConnectionRecordCount . should_equal 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be good to also read xls_sheet one more time before the reload and see that it does not increase the counter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Dec 18, 2024
@mergify mergify bot merged commit 7d3293c into develop Dec 18, 2024
37 of 39 checks passed
@mergify mergify bot deleted the wip/gmt/excel-clear-cache-on-reload branch December 18, 2024 18:24
jdunkerley pushed a commit that referenced this pull request Dec 18, 2024
@GregoryTravis @jdunkerley
Clear excel cache on reload (#11872)
23cf258 
(cherry picked from commit 7d3293c)
somebody1234 pushed a commit that referenced this pull request Dec 24, 2024
@GregoryTravis @somebody1234
Clear excel cache on reload (#11872)
d4e2861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@radeusgd radeusgd radeusgd approved these changes

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clear Excel cache on reload
3 participants
@GregoryTravis @radeusgd @jdunkerley