Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monokai code style and coal dark mode #29

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Monokai code style and coal dark mode #29

merged 2 commits into from
Jul 17, 2020

Conversation

joenash
Copy link
Contributor

@joenash joenash commented Jul 7, 2020

Pull Request Description

This pull request fixes #27 and #11.
For 11: code colour scheme changed to Monokai. Code scheme is now consistent across all 3 colour schemes.
- Most of the changes are done in rouge-highlight-colorful.css (colorful being the name of the old theme, future refactor should rename this)
- There are some changes (namely the background of the code block in the default theme) made in the minimised style.css.
- For the sepia and dark themes, these changes are made in website.css.
For 27: In process of converting to Coal, translating between the css classes in mdbook and those in gitbook, got a bit more work to do to get full coverage.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code has been tested where possible.

@joenash joenash added Category: Dark Theme The documentation's dark theme Change: Non-Breaking A change that will not break links to the site Difficulty: Core Contributor Should only be attempted by a core contributor Priority: Medium Should be completed in the next few sprints labels Jul 7, 2020
@joenash
Copy link
Contributor Author

joenash commented Jul 17, 2020

I think this is good to go for now

@joenash joenash marked this pull request as ready for review July 17, 2020 12:32
@joenash joenash requested a review from iamrecursion as a code owner July 17, 2020 12:32
@joenash joenash merged commit 648393e into sources Jul 17, 2020
@joenash joenash deleted the coal-and-code branch July 17, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Dark Theme The documentation's dark theme Change: Non-Breaking A change that will not break links to the site Difficulty: Core Contributor Should only be attempted by a core contributor Priority: Medium Should be completed in the next few sprints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace darkmode colour scheme with 'coal' scheme from mdbook
1 participant