-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔓 #1171
🔓 #1171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds permissions to the bazel-steward.yaml
workflow file. Specifically, it grants contents: write
and pull-requests: write
permissions. This is likely to allow the Bazel Steward to create and modify pull requests, which is necessary for its automated dependency management functionality, and relates to issue #254.
Highlights
- Permissions: The pull request adds
contents: write
andpull-requests: write
permissions to thebazel-steward.yaml
workflow. - Bazel Steward: The added permissions are intended to enable the Bazel Steward to automatically create and modify pull requests.
Changelog
- .github/workflows/bazel-steward.yaml
- Added
contents: write
permission to allow writing to the repository's contents. - Added
pull-requests: write
permission to allow creating and modifying pull requests.
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A workflow's plight, permissions tight,
To automate with all its might.
Write access granted, pull requests made,
By Bazel Steward, unafraid.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a Bazel Steward workflow to automate dependency updates. The addition of permissions to the workflow is a good security practice. The script itself seems straightforward, but there are a couple of areas for improvement regarding TODOs and branch cleanup.
Merge Readiness
The pull request is almost ready for merging. Addressing the TODO comments in tools/bazel-steward/update.bash
would be beneficial. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
Relates to #254.