Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the great Bazel Steward 🤵 as GitHub Action #1168

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

vorburger
Copy link
Member

Relates to #254.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request introduces a new GitHub Action workflow, bazel-steward.yaml, to automatically keep Bazel dependencies up to date using the Bazel Steward tool. The workflow is scheduled to run daily at 5:30 AM and can also be triggered manually.

Highlights

  • New Workflow: Adds a new GitHub Actions workflow file .github/workflows/bazel-steward.yaml.
  • Bazel Steward Integration: Configures the workflow to use the VirtusLab/bazel-steward action to manage Bazel dependencies.
  • Scheduled Execution: Sets up a cron schedule to run the Bazel Steward daily.
  • Update All PRs: The Bazel Steward is configured to update all PRs via the additional-args: "--update-all-prs" setting.

Changelog

  • .github/workflows/bazel-steward.yaml
    • Creates a new workflow file to run Bazel Steward.
    • Configures the workflow to run on a schedule and manually.
    • Uses the VirtusLab/bazel-steward action to update Bazel dependencies.
    • Sets fetch-depth: 0 to fetch all history for the checkout action.
    • Adds additional-args: "--update-all-prs" to update all PRs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Did you know?

Bazel is named after a type of basilisk, a mythical reptile said to be king of the serpents, because it is intended to be the king of build systems.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a GitHub Action to run Bazel Steward, automating dependency updates. The configuration looks good, but there are a few points to consider.

Summary of Findings

  • TODO in github-personal-token: The github-personal-token is currently a TODO. A token is likely required for the action to function correctly, especially for creating pull requests. Consider adding documentation or a default value.
  • Copyright Year: The copyright year is set to 2025. Please confirm this is the intended year.

Merge Readiness

The pull request introduces a valuable automation feature. However, the github-personal-token needs to be addressed before merging. Also, the copyright year should be confirmed. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.

Comment on lines +35 to +36
# github-personal-token: 'TODO'
additional-args: "--update-all-prs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The github-personal-token is currently a TODO. This likely needs to be configured for the action to function correctly, especially for creating pull requests. Consider adding documentation or a default value if appropriate.

@@ -0,0 +1,36 @@
# SPDX-License-Identifier: Apache-2.0
#
# Copyright 2025 The Enola <https://enola.dev> Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The copyright year is set to 2025. Is this intentional, or should it be the current year?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think the current year actually is? 🤣

@vorburger vorburger merged commit ef83d16 into enola-dev:main Mar 3, 2025
1 of 5 checks passed
@vorburger vorburger deleted the bazel-steward3 branch March 3, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant