-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump loads of stuff using Bazel Steward #1147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates several dependencies in the MODULE.bazel
file and the maven_install.json
file. The updates were generated with the help of Bazel Steward, with manual fixes applied for issues related to Bazel Steward and Enola. The dependencies updated include RDF4J, gRPC, protobuf, jackson-databind, kubernetes client, several maven related libraries, spotbugs, java-diff-utils, jsoup, log4j, snakeyaml, and others.
Highlights
- Dependency Updates: The primary focus of this pull request is to bump the versions of various dependencies managed by Bazel. This includes libraries like RDF4J (from 5.1.1 to 5.1.2), protobuf (from 4.29.2 to 4.29.3), jackson-databind (from 2.13.5 to 2.18.3), kubernetes client (from 19.0.0 to 19.0.2), and several others.
- Maven Connector Updates: Several Maven-related dependencies have been updated, including
eu.maveniverse.maven.mima.runtime
,eu.maveniverse.maven.mima
,org.apache.maven.resolver
, andorg.apache.maven
. These updates likely bring in new features, bug fixes, and performance improvements to the Maven connector. - Bazel Steward Integration: This pull request highlights the use of Bazel Steward for managing and updating dependencies. The author notes that manual fixes were applied to address specific issues encountered with Bazel Steward, indicating a hands-on approach to ensure compatibility and stability.
Changelog
Click here to see the changelog
- MODULE.bazel
- Updated RDF4J_VERSION from 5.1.1 to 5.1.2.
- Updated grpc-google-cloud-pubsub-v1 and proto-google-cloud-pubsub-v1 from 0.1.24 to 0.13.0.
- Updated protobuf-java and protobuf-java-util from 4.29.2 to 4.29.3.
- Updated jackson-databind from 2.13.5 to 2.18.3.
- Updated kubernetes:client-java from 19.0.0 to 19.0.2.
- Updated ch.vorburger.exec:exec from 3.1.5 to 3.3.0.
- Updated info.picocli:picocli from 4.7.5 to 4.7.6.
- Updated org.snakeyaml:snakeyaml-engine from 2.8 to 2.9.
- Updated org.yaml:snakeyaml from 2.3 to 2.4.
- Updated org.slf4j:slf4j-jdk14 and org.slf4j:slf4j-simple from 2.0.16 to 2.0.17.
- Updated org.apache.logging.log4j:log4j-to-jul from 2.24.0 to 2.24.3.
- Updated com.github.spotbugs:spotbugs-annotations from 4.8.6 to 4.9.1.
- Updated io.github.java-diff-utils:java-diff-utils from 4.12 to 4.15.
- Updated org.jsoup:jsoup from 1.18.1 to 1.18.3.
- Updated eu.maveniverse.maven.mima.runtime, eu.maveniverse.maven.mima, and eu.maveniverse.maven.mima.extensions from 2.4.21 to 2.4.22.
- Updated org.apache.maven.resolver:maven-resolver-api and maven-resolver-util from 1.9.22 to 2.0.6.
- maven_install.json
- Updated shasums and versions for multiple artifacts, including ch.vorburger.exec, jackson libraries, spotbugs-annotations, google api libraries, protobuf libraries, maven resolver libraries, jsoup, slf4j libraries, snakeyaml libraries, and kubernetes client libraries.
- Removed conflict resolution for jackson-databind.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is the primary purpose of a build tool like Bazel?
Click here for the answer
Bazel is a build tool used for automating the process of compiling, linking, and packaging software. It ensures that builds are reproducible and efficient by caching build artifacts and only rebuilding what's necessary.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates various dependencies using Bazel Steward. The changes seem straightforward, involving version bumps in MODULE.bazel and corresponding updates to shasums and versions in maven_install.json. No specific style guide was provided, so I'm assuming adherence to general best practices for Bazel and Java dependency management.
Merge Readiness
The pull request updates dependencies, which is generally a safe operation. However, it's crucial to ensure that these updates don't introduce any regressions or compatibility issues. While I can't directly approve this pull request, I recommend verifying that all tests pass and that the updated dependencies function as expected before merging. Given the absence of any identified issues, the pull request appears to be in good shape for merging, pending the aforementioned verification by other reviewers.
Relates to #254:
This is the 1st version bump created with help from the very awesome https://virtuslab.github.io/bazel-steward - Thank You @lukaszwawrzyk !
With manually debugged and hand applied fixes for: