-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (build): Add Bazel Steward #1145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds Bazel Steward to the project, as related to issue #254. It introduces a .bazel-steward.yaml
file to configure Bazel Steward for Maven dependency updates. It also adds a tools/bazel-steward/update.bash
script to launch Bazel Steward. Finally, it adds a TODO comment to .github/dependabot.yml
.
Highlights
- Bazel Steward Configuration: Adds
.bazel-steward.yaml
to configure Bazel Steward for Maven dependency management, specifying the repository name. - Bazel Steward Update Script: Introduces
tools/bazel-steward/update.bash
to execute Bazel Steward, using coursier to launch the steward. - Dependabot Configuration: Adds a TODO comment to
.github/dependabot.yml
regarding a Dependabot issue.
Changelog
- .bazel-steward.yaml
- Added a new file to configure Bazel Steward for Maven dependency updates.
- Specifies the repository name as enola_maven.
- .github/dependabot.yml
- Added a TODO comment referencing a Dependabot issue.
- tools/bazel-steward/update.bash
- Added a new script to launch Bazel Steward using coursier.
- Uses bazel-steward version 1.6.0.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is Coursier, the tool used in the update.bash script to launch Bazel Steward?
Click here for the answer
Coursier is a dependency resolver and package fetcher for Scala and Java. It is used to resolve and fetch the dependencies required to run Bazel Steward.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds Bazel Steward to the project, which automates dependency updates. The changes include adding a Bazel Steward configuration file, updating the Dependabot configuration, and adding a script to run Bazel Steward. Overall, the changes seem reasonable, but there are a few areas that could be improved.
Summary of Findings
- TODO comments: The pull request introduces TODO comments in
.github/dependabot.yml
andtools/bazel-steward/update.bash
. Consider addressing these or providing more context on when they will be addressed. - Coursier installation: The
tools/bazel-steward/update.bash
script usescs launch
, but it's unclear where Coursier is installed or how it's managed. Clarify this in the script or documentation.
Merge Readiness
The pull request introduces Bazel Steward to automate dependency updates, which is a valuable addition. However, the TODO comments and the unclear Coursier installation should be addressed before merging. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
# TODO And where does coursier come from?! ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TODO comment mentions Coursier. It would be helpful to provide more information on how Coursier is installed or managed, perhaps with a comment or link to documentation.
# TODO And where does coursier come from?! ;-) | |
# TODO And where does coursier come from?! ;-) Consider using https://github.com/coursier/setup-action to install it, or document where it's expected to be installed. |
ce117ca
to
0d38524
Compare
0d38524
to
3e860f4
Compare
63389b4
to
5fb9627
Compare
5fb9627
to
dcf9abf
Compare
This is now at a state where it works well enough to already be useful. It just created https://github.com/enola-dev/enola/branches/all?query=bazel-steward. VirtusLab/bazel-steward#44 would be quite cool, but is not a reason to hold off. VirtusLab/bazel-steward#403 turned out to be (very) confusing, but not as blocking as I thought at first. Triggering this by a GitHub Action is still TBD, but will be separate. |
Relates to #254.