FitSumEvaluation Ver1.1 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matthew,
Please check completed code, I have sent pull request and you can also find it with attached zip file of source.
App will work with both iPhone and iPad.
Another thing that I'v noticed is that you're using CoreData objects in AppDelegate class. It doesn't follow MVC pattern programming guidelines. There must be a separate module for communicating with CoreData instead of using it via AppDelegate. I created IQDatabaseManager for this purpose.
Here is the github link:-
https://github.com/hackiftekhar/IQDatabaseManager
I just released v1.0 today just for you. Please look at IQDatabaseManager.h header file. It contains convenience methods to communicate with CoreData native classes. It also contains category(download) methods to cache data(images(UIImage) and web service response(NSData)) using CoreData. It can also be used to store NSURLRequest object for storing offline data that can be sent when an internet connection found.
Let me know if you have any query related to the source code.
Thanks & Regards,
Faizan Q.