Change grok performance_metadata to be disabled by default (opensearc…

…h-project#4235) Signed-off-by: Taylor Gray <[email protected]>
engechas · Mar 5, 2024 · afc85e0 · afc85e0
1 parent e76d831
commit afc85e0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.../src/main/java/org/opensearch/dataprepper/plugins/processor/grok/GrokProcessorConfig.java b/.../src/main/java/org/opensearch/dataprepper/plugins/processor/grok/GrokProcessorConfig.java
@@ -100,7 +100,7 @@ public static GrokProcessorConfig buildConfig(final PluginSetting pluginSetting)
                 pluginSetting.getStringOrDefault(GROK_WHEN, null),
                 pluginSetting.getTypedList(TAGS_ON_MATCH_FAILURE, String.class),
                 pluginSetting.getTypedList(TAGS_ON_TIMEOUT, String.class),
-                pluginSetting.getBooleanOrDefault(INCLUDE_PERFORMANCE_METADATA, true));
+                pluginSetting.getBooleanOrDefault(INCLUDE_PERFORMANCE_METADATA, false));
     }
 
     public boolean isBreakOnMatch() {

diff --git a/...test/java/org/opensearch/dataprepper/plugins/processor/grok/GrokProcessorConfigTests.java b/...test/java/org/opensearch/dataprepper/plugins/processor/grok/GrokProcessorConfigTests.java
@@ -77,7 +77,7 @@ public void testDefault() {
         assertThat(grokProcessorConfig.getGrokWhen(), equalTo(null));
         assertThat(grokProcessorConfig.getTagsOnMatchFailure(), equalTo(Collections.emptyList()));
         assertThat(grokProcessorConfig.getTagsOnTimeout(), equalTo(Collections.emptyList()));
-        assertThat(grokProcessorConfig.getIncludePerformanceMetadata(), equalTo(true));
+        assertThat(grokProcessorConfig.getIncludePerformanceMetadata(), equalTo(false));
     }
 
     @Test
@@ -93,7 +93,7 @@ public void testValidConfig() {
                 TEST_PATTERN_DEFINITIONS,
                 TEST_TIMEOUT_MILLIS,
                 TEST_TARGET_KEY,
-                false);
+                true);
 
         final GrokProcessorConfig grokProcessorConfig = GrokProcessorConfig.buildConfig(validPluginSetting);
 
@@ -107,7 +107,7 @@ public void testValidConfig() {
         assertThat(grokProcessorConfig.getTargetKey(), equalTo(TEST_TARGET_KEY));
         assertThat(grokProcessorConfig.isNamedCapturesOnly(), equalTo(false));
         assertThat(grokProcessorConfig.getTimeoutMillis(), equalTo(TEST_TIMEOUT_MILLIS));
-        assertThat(grokProcessorConfig.getIncludePerformanceMetadata(), equalTo(false));
+        assertThat(grokProcessorConfig.getIncludePerformanceMetadata(), equalTo(true));
     }
 
     @Test