MSI-3110-In-Store-Pickup-delivery-not-available-for-order-with-Config…

…urable-product. Fix issue of In-Store Pikcup availability with composite products. Fix issue of In-Store Pickup availability with repeatable SKUs.
engcom-Golf · Jul 2, 2020 · 5861ff3 · 5861ff3
1 parent 8aa3b30
commit 5861ff3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/InventoryInStorePickup/Model/SearchCriteria/ResolveIntersection.php b/InventoryInStorePickup/Model/SearchCriteria/ResolveIntersection.php
@@ -53,7 +53,9 @@ public function resolve(
         $extensionAttributes = $searchRequest->getExtensionAttributes();
         $skus = [];
         foreach ($extensionAttributes->getProductsInfo() as $item) {
-            $skus[] = $item->getSku();
+            if (!in_array($item->getSku(), $skus)) {
+                $skus[] = $item->getSku();
+            }
         }
 
         $codes = $this->getPickupLocationIntersectionForSkus->execute($skus);

diff --git a/InventoryInStorePickupApi/Test/Api/GetPickupLocationsTest.php b/InventoryInStorePickupApi/Test/Api/GetPickupLocationsTest.php
@@ -122,6 +122,12 @@ public function executeIntersectionSearchDataProvider(): array
                             [
                                 'sku' => 'SKU-3',
                             ],
+                            [
+                                'sku' => 'SKU-3',
+                            ],
+                            [
+                                'sku' => 'SKU-3',
+                            ],
                         ],
                     ],
                     'scopeType' => 'website',

diff --git a/...ryInStorePickupShipping/Model/Carrier/Validation/PickupLocationsAvailabilityValidator.php b/...ryInStorePickupShipping/Model/Carrier/Validation/PickupLocationsAvailabilityValidator.php
@@ -132,6 +132,10 @@ private function getSearchRequestExtension(array $items): SearchRequestExtension
     {
         $productsInfo = [];
         foreach ($items as $item) {
+            if (!empty($item->getChildren())) {
+                continue;
+            }
+
             $productsInfo[] = $this->productInfoFactory->create(['sku' => $item->getSku()]);
         }