Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ipfs.service): add timeout to get #677

Merged
merged 6 commits into from
Jan 16, 2025
Merged

feat(ipfs.service): add timeout to get #677

merged 6 commits into from
Jan 16, 2025

Conversation

jrhender
Copy link
Collaborator

@jrhender jrhender commented Jan 15, 2025 •
edited
Loading

This PR adds a timeout to the ipfs.service get

Todo:

  • Decide if return value needs to be change or add catch to did.service
  • Test locally

JGiter
JGiter reviewed Jan 15, 2025
View reviewed changes
package.json Show resolved Hide resolved
@jrhender jrhender marked this pull request as ready for review January 16, 2025 05:31
@JGiter JGiter force-pushed the fix-ipfs-service-get-timeout-2 branch from 7019ab3 to 8e6cb8c Compare January 16, 2025 07:55
@JGiter JGiter merged commit aef5f19 into develop Jan 16, 2025
13 of 14 checks passed
@JGiter JGiter deleted the fix-ipfs-service-get-timeout-2 branch January 16, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGiter JGiter JGiter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrhender @JGiter