Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless patterns from unasync.py #779

Merged
merged 3 commits into from
Aug 13, 2023
Merged

Remove useless patterns from unasync.py #779

merged 3 commits into from
Aug 13, 2023

Conversation

karpetrosyan
Copy link
Member

Some patterns became obsolete, but they were not deleted.

I also included a check for unused patterns.

@karpetrosyan
Copy link
Member Author

Do we need a changelog?

@tomchristie
Copy link
Member

We don't, no.
It's a tooling change, not a user-facing behavioural change.

@karpetrosyan karpetrosyan requested a review from a team August 11, 2023 05:27
@Kludex
Copy link
Member

Kludex commented Aug 11, 2023

Should we move this to scripts/?

@karpetrosyan
Copy link
Member Author

I think it's a job for #638

@karpetrosyan karpetrosyan merged commit b649bb0 into encode:master Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeloliverx michaeloliverx michaeloliverx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karpetrosyan @tomchristie @Kludex @michaeloliverx