Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get owner of handle #232

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Nov 24, 2023

No description provided.

@coveralls
Copy link

coveralls commented Nov 24, 2023

Pull Request Test Coverage Report for Build 6980743420

  • 35 of 45 (77.78%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 83.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
c_src/quicer_listener.c 9 10 90.0%
c_src/quicer_connection.c 12 15 80.0%
c_src/quicer_stream.c 11 14 78.57%
src/quicer_nif.erl 0 3 0.0%
Totals Coverage Status
Change from base Build 6958285280: 0.06%
Covered Lines: 3438
Relevant Lines: 4141

💛 - Coveralls

@qzhuyan qzhuyan force-pushed the dev/william/api-get-owner branch from 4029833 to 6bff129 Compare November 24, 2023 12:08
Get
- listener owner
- connection owner
- stream owner
@qzhuyan qzhuyan force-pushed the dev/william/api-get-owner branch from 6bff129 to 7d10be8 Compare November 24, 2023 12:28
@qzhuyan qzhuyan changed the title feat: get owners of handle feat: get owner of handle Nov 24, 2023
@qzhuyan qzhuyan marked this pull request as ready for review November 24, 2023 12:43
goto exit;
}
res = SUCCESS(enif_make_pid(env, &(c_ctx->owner->Pid)));
;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, extra ;

@qzhuyan qzhuyan merged commit 9dbb916 into emqx:main Nov 24, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants