Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Output token {miyoocfw} for MiyooCFW #810

Closed
wants to merge 20 commits into from

Conversation

juliadin
Copy link
Contributor

@juliadin juliadin commented Nov 7, 2023

I want to add sorting support for MiyooCFW https://github.com/TriForceX/MiyooCFW/wiki/

it can be used on the compact handheld firmware for some Bittboy, powkiddy (V/Q 20/90) and PocketGo devices. Work in progress

@juliadin juliadin changed the title Feature Output token {miyoocfw} for MiyooCFW Feature: Output token {miyoocfw} for MiyooCFW Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:juliadin/igir#outputToken_miyooCFW" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@juliadin juliadin force-pushed the outputToken_miyooCFW branch from 881b4df to 0443a99 Compare November 7, 2023 21:52
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #810 (881b4df) into main (ee50d93) will increase coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 881b4df differs from pull request most recent head 0443a99. Consider uploading reports for the commit 0443a99 to get more accurate results

@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
+ Coverage   93.50%   93.51%   +0.01%     
==========================================
  Files          85       85              
  Lines        5200     5210      +10     
  Branches     1183     1185       +2     
==========================================
+ Hits         4862     4872      +10     
  Misses        320      320              
  Partials       18       18              
Files Coverage Δ
src/modules/argumentsParser.ts 98.12% <ø> (ø)
src/types/gameConsole.ts 100.00% <100.00%> (ø)
src/types/outputFactory.ts 100.00% <100.00%> (ø)

@juliadin juliadin closed this Nov 7, 2023
@juliadin juliadin deleted the outputToken_miyooCFW branch November 7, 2023 22:18
Copy link

github-actions bot commented Dec 8, 2023

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant