Ignore Blob errors, sort returned methods list in Get4ByteMethodSigna…

…tures precompile

arbstate/inbox.go

@@ -63,6 +63,11 @@ const maxZeroheavyDecompressedLen = 101*MaxDecompressedLen/100 + 64
 const MaxSegmentsPerSequencerMessage = 100 * 1024
 const MinLifetimeSecondsForDataAvailabilityCert = 7 * 24 * 60 * 60 // one week
 
+var (
+	ErrNoBlobReader          = errors.New("blob batch payload was encountered but no BlobReader was configured")
+	ErrInvalidBlobDataFormat = errors.New("blob batch data is not a list of hashes as expected")
+)
+
 func parseSequencerMessage(ctx context.Context, batchNum uint64, batchBlockHash common.Hash, data []byte, daProviders []DataAvailabilityProvider, keysetValidationMode KeysetValidationMode) (*sequencerMessage, error) {
 	if len(data) < 40 {
 		return nil, errors.New("sequencer message missing L1 header")
@@ -110,7 +115,7 @@ func parseSequencerMessage(ctx context.Context, batchNum uint64, batchBlockHash
 			if IsDASMessageHeaderByte(payload[0]) {
 				log.Error("No DAS Reader configured, but sequencer message found with DAS header")
 			} else if IsBlobHashesHeaderByte(payload[0]) {
-				return nil, errors.New("blob batch payload was encountered but no BlobReader was configured")
+				return nil, ErrNoBlobReader
 			}
 		}
 	}
@@ -341,7 +346,7 @@ func (b *dAProviderForBlobReader) RecoverPayloadFromBatch(
 ) ([]byte, error) {
 	blobHashes := sequencerMsg[41:]
 	if len(blobHashes)%len(common.Hash{}) != 0 {
-		return nil, fmt.Errorf("blob batch data is not a list of hashes as expected")
+		return nil, ErrInvalidBlobDataFormat
 	}
 	versionedHashes := make([]common.Hash, len(blobHashes)/len(common.Hash{}))
 	for i := 0; i*32 < len(blobHashes); i += 1 {

precompiles/precompile.go

@@ -4,10 +4,12 @@
 package precompiles
 
 import (
+	"bytes"
 	"errors"
 	"fmt"
 	"math/big"
 	"reflect"
+	"sort"
 	"strconv"
 	"strings"
 	"unicode"
@@ -783,6 +785,9 @@ func (p *Precompile) Get4ByteMethodSignatures() [][4]byte {
 	for sig := range p.methods {
 		ret = append(ret, sig)
 	}
+	sort.Slice(ret, func(i, j int) bool {
+		return bytes.Compare(ret[i][:], ret[j][:]) < 0
+	})
 	return ret
 }
 

system_tests/state_fuzz_test.go

@@ -119,6 +119,20 @@ func (c noopChainContext) GetHeader(common.Hash, uint64) *types.Header {
 	return nil
 }
 
+var ignoreErrors = []error{
+	arbstate.ErrNoBlobReader,
+	arbstate.ErrInvalidBlobDataFormat,
+}
+
+func shouldIgnore(err error) bool {
+	for _, e := range ignoreErrors {
+		if errors.Is(err, e) {
+			return true
+		}
+	}
+	return false
+}
+
 func FuzzStateTransition(f *testing.F) {
 	f.Fuzz(func(t *testing.T, compressSeqMsg bool, seqMsg []byte, delayedMsg []byte) {
 		chainDb := rawdb.NewMemoryDatabase()
@@ -189,7 +203,7 @@ func FuzzStateTransition(f *testing.F) {
 			delayedMessages:       delayedMessages,
 		}
 		_, err = BuildBlock(statedb, genesis, noopChainContext{}, params.ArbitrumOneChainConfig(), inbox, seqBatch)
-		if err != nil {
+		if err != nil && !shouldIgnore(err) {
 			// With the fixed header it shouldn't be possible to read a delayed message,
 			// and no other type of error should be possible.
 			panic(err)